conn_sock: do not fail on EAGAIN #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 6287bd8 introduced the regression. writes to the attached sockets must be blocking, otherwise the write_back_to_remote_consoles() shutdowns the socket when write fails with EAGAIN. I've verified the original issue fixed with commit 62887bd is not reintroduced with this patch. Closes: containers#236 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
This was referenced Feb 2, 2021
Closed
|
LGTM this may also help with failures I'm seeing here containers/podman#8979 |
|
I may be able to get to a release later today, or someone else could pick it up if I'm too slow 😇 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit 6287bd8 introduced the
regression.
writes to the attached sockets must be blocking, otherwise the
write_back_to_remote_consoles() shutdowns the socket when write fails
with EAGAIN.
I've verified the original issue fixed with commit 62887bd is not
reintroduced with this patch.
Closes: #236
Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com