crun: write setgroups=deny when mapping a single uid/gid #1089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maleadt
force-pushed
the
setgroups_deny
branch
2 times, most recently
from
919d207
to
32a2a7c
Compare
giuseppe
reviewed
Dec 7, 2022
| @@ -2868,6 +2887,7 @@ libcrun_set_usernamespace (libcrun_container_t *container, pid_t pid, libcrun_er | |||
| } | |||
|
|
|||
| single_mapping = format_mount_mapping (container->container_uid, container->host_uid, 1, &single_mapping_len, true); | |||
|
|
|||
maleadt
force-pushed
the
setgroups_deny
branch
from
32a2a7c
to
3dcac98
Compare
flouthoc
approved these changes
Dec 7, 2022
There was a problem hiding this comment.
LGTM comment https://github.com/containers/crun/pull/1089/files#r1042260747 is still unresolved though
|
you need to run |
maleadt
force-pushed
the
setgroups_deny
branch
from
3dcac98
to
ed1dbe8
Compare
|
Done. |
|
@lsm5 fedora-rawhide-mockbuild is failing |
|
nit, if you are going to re-push, could you make the first line shorter in the commit message (e.g. |
|
tests failures do not depend on this PR. It seems github moved to cgroup v2, opened a PR: #1090 |
maleadt
force-pushed
the
setgroups_deny
branch
from
ed1dbe8
to
eb79f1e
Compare
|
could you please rebase on top of main? |
Signed-off-by: Tim Besard <tim.besard@gmail.com>
maleadt
force-pushed
the
setgroups_deny
branch
from
eb79f1e
to
5e3ef32
Compare
|
Sure; done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1088
cc @giuseppe