cgroup: set the memory limit on the system scope #1217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giuseppe
added a commit
to giuseppe/libpod
that referenced
this pull request
May 19, 2023
b25b330 introduced this behaviour. It was fine at the time because we didn't support "container update", so the limit could not be changed at runtime. Since it is not possible to change the memory limit at runtime, read the limit as reported from the cgroup. containers/crun#1217 is required for crun. [NO NEW TESTS NEEDED] needs a new crun release Closes: containers#18621 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
This was referenced May 19, 2023
giuseppe
added a commit
to giuseppe/libpod
that referenced
this pull request
May 19, 2023
b25b330 introduced this behaviour. It was fine at the time because we didn't support "container update", so the limit could not be changed at runtime. Since it is not possible to change the memory limit at runtime, read the limit as reported from the cgroup. containers/crun#1217 is required for crun. [NO NEW TESTS NEEDED] needs a new crun release Closes: containers#18621 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
added a commit
to giuseppe/libpod
that referenced
this pull request
May 19, 2023
b25b330 introduced this behaviour. It was fine at the time because we didn't support "container update", so the limit could not be changed at runtime. Since it is not possible to change the memory limit at runtime, read the limit as reported from the cgroup. containers/crun#1217 is required for crun. [NO NEW TESTS NEEDED] needs a new crun release Closes: containers#18621 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
set-mem-limit-cgroup-systemd
branch
from
4a24b6a
to
950b4f6
Compare
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
when updating the memory limit, we now set it also on the systemd scope. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
set-mem-limit-cgroup-systemd
branch
from
950b4f6
to
6494b69
Compare
giuseppe
added a commit
to giuseppe/libpod
that referenced
this pull request
May 19, 2023
b25b330 introduced this behaviour. It was fine at the time because we didn't support "container update", so the limit could not be changed at runtime. Since it is not possible to change the memory limit at runtime, read the limit as reported from the cgroup. containers/crun#1217 is required for crun. [NO NEW TESTS NEEDED] needs a new crun release Closes: containers#18621 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
|
LGTM |
|
@flouthoc PTAL |
giuseppe
added a commit
to giuseppe/libpod
that referenced
this pull request
May 19, 2023
b25b330 introduced this behaviour. It was fine at the time because we didn't support "container update", so the limit could not be changed at runtime. Since it is not possible to change the memory limit at runtime, read the limit as reported from the cgroup. containers/crun#1217 is required for crun. Closes: containers#18621 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
|
Time to cut a crun release? |
giuseppe
added a commit
to giuseppe/libpod
that referenced
this pull request
May 19, 2023
b25b330 introduced this behaviour. It was fine at the time because we didn't support "container update", so the limit could not be changed at runtime. Since it is not possible to change the memory limit at runtime, read the limit as reported from the cgroup. containers/crun#1217 is required for crun. Closes: containers#18621 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
added a commit
to giuseppe/libpod
that referenced
this pull request
May 19, 2023
b25b330 introduced this behaviour. It was fine at the time because we didn't support "container update", so the limit could not be changed at runtime. Since it is not possible to change the memory limit at runtime, read the limit as reported from the cgroup. containers/crun#1217 is required for crun. Closes: containers#18621 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
opened #1220 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when updating the memory limit, we now set it also on the systemd scope.