-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Podman update doesn't have effect on memory limit #18621
Labels
kind/bug
Categorizes issue or PR as related to a bug.
locked - please file new issue/PR
Assist humans wanting to comment on an old issue or PR with locked comments.
Comments
I think we are using the limit from the container configuration instead of reading it from the cgroup. The More details here: #15067 |
giuseppe
added a commit
to giuseppe/libpod
that referenced
this issue
May 19, 2023
b25b330 introduced this behaviour. It was fine at the time because we didn't support "container update", so the limit could not be changed at runtime. Since it is not possible to change the memory limit at runtime, read the limit as reported from the cgroup. containers/crun#1217 is required for crun. [NO NEW TESTS NEEDED] needs a new crun release Closes: containers#18621 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
I've opened a PR to fix it: #18630 It also needs containers/crun#1217 in crun |
giuseppe
added a commit
to giuseppe/libpod
that referenced
this issue
May 19, 2023
b25b330 introduced this behaviour. It was fine at the time because we didn't support "container update", so the limit could not be changed at runtime. Since it is not possible to change the memory limit at runtime, read the limit as reported from the cgroup. containers/crun#1217 is required for crun. [NO NEW TESTS NEEDED] needs a new crun release Closes: containers#18621 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
added a commit
to giuseppe/libpod
that referenced
this issue
May 19, 2023
b25b330 introduced this behaviour. It was fine at the time because we didn't support "container update", so the limit could not be changed at runtime. Since it is not possible to change the memory limit at runtime, read the limit as reported from the cgroup. containers/crun#1217 is required for crun. [NO NEW TESTS NEEDED] needs a new crun release Closes: containers#18621 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
added a commit
to giuseppe/libpod
that referenced
this issue
May 19, 2023
b25b330 introduced this behaviour. It was fine at the time because we didn't support "container update", so the limit could not be changed at runtime. Since it is not possible to change the memory limit at runtime, read the limit as reported from the cgroup. containers/crun#1217 is required for crun. [NO NEW TESTS NEEDED] needs a new crun release Closes: containers#18621 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
added a commit
to giuseppe/libpod
that referenced
this issue
May 19, 2023
b25b330 introduced this behaviour. It was fine at the time because we didn't support "container update", so the limit could not be changed at runtime. Since it is not possible to change the memory limit at runtime, read the limit as reported from the cgroup. containers/crun#1217 is required for crun. Closes: containers#18621 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
added a commit
to giuseppe/libpod
that referenced
this issue
May 19, 2023
b25b330 introduced this behaviour. It was fine at the time because we didn't support "container update", so the limit could not be changed at runtime. Since it is not possible to change the memory limit at runtime, read the limit as reported from the cgroup. containers/crun#1217 is required for crun. Closes: containers#18621 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
added a commit
to giuseppe/libpod
that referenced
this issue
May 19, 2023
b25b330 introduced this behaviour. It was fine at the time because we didn't support "container update", so the limit could not be changed at runtime. Since it is not possible to change the memory limit at runtime, read the limit as reported from the cgroup. containers/crun#1217 is required for crun. Closes: containers#18621 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
github-actions
bot
added
the
locked - please file new issue/PR
Assist humans wanting to comment on an old issue or PR with locked comments.
label
Aug 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
kind/bug
Categorizes issue or PR as related to a bug.
locked - please file new issue/PR
Assist humans wanting to comment on an old issue or PR with locked comments.
Issue Description
`podman inspect minecraft`
Then I want to update the memory limit:
podman update --memory="2g" minecraft
.Still
podman stats
shows:Steps to reproduce the issue
Steps to reproduce the issue
podman update --memory="2g" <container>
podman stats
Describe the results you received
The updated memory limit doesn't seem to have any effect.
Describe the results you expected
The memory limit would change and
podman stats
would show that.podman info output
Podman in a container
No
Privileged Or Rootless
Rootless
Upstream Latest Release
Yes
Additional environment details
Additional environment details
Additional information
Additional information like issue happens only occasionally or issue happens with a particular architecture or on a particular setting
The text was updated successfully, but these errors were encountered: