Adapt crun to work with Podman's checkpoint/restore expectations #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The initial checkpoint implementation did not delete the state of the checkpointed container. Looking at what Podman expects from the runtime this adapts crun to work as Podman expects it for checkpoint/restore. Signed-off-by: Adrian Reber <areber@redhat.com>
To restore a container Podman calls conmon and conmon calls the runtime. This adds all parameters which conmon passes down to the runtime to crun, so that crun actually restores the container. This are the parameters --bundle and --pid-file. This also now expects that the to be restored container has been completely deleted from the /run directory and therefore --bundle becomes necessary to know where to find the container. With this change to restore and the previous change to checkpoint, Podman can now use crun to checkpoint and restore a container. The restored container does not yet have the correct network namespace as this is not yet handled. Signed-off-by: Adrian Reber <areber@redhat.com>
This adapts the checkpoint/restore test to succeed with previous changes to checkpoint/restore. Signed-off-by: Adrian Reber <areber@redhat.com>
adrianreber
force-pushed
the
crun-checkpoint-2
branch
from
cb92cb7
to
e4cbb64
Compare
|
thanks, LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The still hidden "_checkpoint" and "_restore" commands were not yet tested with Podman.
With the changes in this PR I am able to use checkpoint/restore from Podman with crun.
The restored container is not yet running in the correct network namespace, but the container is restored and Podman sees it as running. It almost seems to work now in combination with Podman.
The one thing missing for Podman using crun for checkpoint/restore is crun telling CRIU to restore the container into the network namespace created by Podman/CNI.
This continues #71 to fully support checkpoint/restore in crun.