Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt crun to work with Podman's checkpoint/restore expectations #321

Merged
merged 3 commits into from
Apr 9, 2020
Merged

Adapt crun to work with Podman's checkpoint/restore expectations #321

merged 3 commits into from
Apr 9, 2020

Commits on Apr 9, 2020

  1. Delete the container after a checkpoint 

    The initial checkpoint implementation did not delete the state of the
checkpointed container. Looking at what Podman expects from the runtime
this adapts crun to work as Podman expects it for checkpoint/restore.

Signed-off-by: Adrian Reber <areber@redhat.com>
    @adrianreber
    adrianreber committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    8c9f1d9 View commit details
    Browse the repository at this point in the history

  2. Adapt restore to what Podman expects 

    To restore a container Podman calls conmon and conmon calls the runtime.

This adds all parameters which conmon passes down to the runtime to
crun, so that crun actually restores the container. This are the
parameters --bundle and --pid-file.

This also now expects that the to be restored container has been
completely deleted from the /run directory and therefore --bundle
becomes necessary to know where to find the container.

With this change to restore and the previous change to checkpoint,
Podman can now use crun to checkpoint and restore a container.

The restored container does not yet have the correct network namespace
as this is not yet handled.

Signed-off-by: Adrian Reber <areber@redhat.com>
    @adrianreber
    adrianreber committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    9f97c1c View commit details
    Browse the repository at this point in the history

  3. Adapt checkpoint/restore test 

    This adapts the checkpoint/restore test to succeed with previous changes
to checkpoint/restore.

Signed-off-by: Adrian Reber <areber@redhat.com>
    @adrianreber
    adrianreber committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    e4cbb64 View commit details
    Browse the repository at this point in the history