Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuse-overlayfs: try alternative whiteout on ENOTSUP #19

Merged
merged 2 commits into from
Oct 16, 2018

Conversation

giuseppe
Copy link
Member

@giuseppe giuseppe commented Oct 5, 2018

if mknod fails with ENOTSUP then use the .wh.FILE variant.

Closes: #17

Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com

@rhatdan
Copy link
Member

rhatdan commented Oct 5, 2018

LGTM except tests are failing.

if mknod fails with ENOTSUP then use the .wh.FILE variant.

Closes: containers#17

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe
Copy link
Member Author

giuseppe commented Oct 6, 2018

the CI needed an additional package, tests are fine now. @vbatts does this PR solve the issue you've seen?

@vbatts
Copy link
Contributor

vbatts commented Oct 8, 2018

something is not right with this now. I haven't even made it to fully testing #17, but just on the cd /tmp/merged.

Since I happen to have a large enough $HOME folder and a $PS1 that looks for a .git folder, with this fix now cd /tmp/merged causes fuse-overlayfs to freeze when my $PS1 scans for git changes. I can't crtl+c, only killall -9 fuse-overlayfs and umount /tmp/merged to cleanup.

@vbatts
Copy link
Contributor

vbatts commented Oct 8, 2018

(this freeze does not happen in 79c70fd)

@vbatts
Copy link
Contributor

vbatts commented Oct 8, 2018

oh! but the freeze does happen in 1c72a1a. So it isn't this PR, but a bisect between #13, #14, and #15

@giuseppe
Copy link
Member Author

I am still investigating, I've tried with some big git repositories I've under $HOME but I am still unable to reproduce the freeze.

The only patch that could introduce such issue seems to be b3898da

Does it work for you if you revert that commit?

Also, what do you see if you use --debug or attach gdb/strace to it? Where is it hanging?

@giuseppe
Copy link
Member Author

I am merging this PR as it also solves a problem with the CI

@giuseppe giuseppe merged commit 5e0b422 into containers:master Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants