Adding TCP DNS listener #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfergeau
reviewed
May 26, 2023
There was a problem hiding this comment.
Looks good to me, thanks for the PR!
Can you add a signed-off-by to your commit? https://github.com/containers/gvisor-tap-vsock/pull/223/checks?check_run_id=13702149647 has more details about this.
nhart12
force-pushed
the
main
branch
2 times, most recently
from
70d00f2
to
762cde0
Compare
cfergeau
approved these changes
Jun 7, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfergeau, nhart12 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Nathan Hart <nhart12@gmail.com>
|
I've force-pushed to your branch to resolve minor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dig +tcp lookups were not working inside of the virtual network. When a UDP dns lookup returns a response bigger than the UDP packet size most DNS clients fall back on TCP which would timeout.
This PR simply adds a secondary DNS server listening on TCP 53