Rename ociRef.NewImageDestination to ociRef.NewLayoutDestination

[runcom]

Under package oci there will be also an OCI image destination which will support fetching images (like Docker) from registries (one day...)

It makes sense to me to rename the functions now so we don't really break so many people (and since a lot is changing these days...)

@mtrmac WDYT?

[mtrmac]

Sure, let’s do it now. Though OCIImageLayoutDestination is a bit of a mouthful; would just OCIImageDestination work? Or OCIDirectoryDestination to be specific that this is unpacked, not a single file, nor an installed image.

[runcom]

OCILayoutDestination, sounds good?

[mtrmac]

Works for me.

[runcom]

so there is oci.NewReference which then can do ociRef.NewImageDestination - I'll do ociRef.NewLayoutDestination

[mtrmac]

That would not conform to ImageReference, and anyway an ImageReference to a local directory and an ImageReference to a remote registry are different things with different concepts and semantics.

It is perfectly fine to have them in the same package, but they should be separate ImageTransports with separate ImageReference implementations.

[mtrmac]

i.e. oci{Layout,Registry}{Transport,Reference}' types. The references can be of course created using helper functions (i.e. without going through theTransports),oci.NewLayoutReferenceandoci.NewRegistryReference`.

[runcom]

oci.NewLayoutReferenceandoci.NewRegistryReference`.

👍

[runcom]

@mtrmac re-thought about this, making a PR