-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dockerImageDestination.SupportedManifestMIMETypes may be incorrect #86
Comments
We should probably test if V2 is really supported, otherwise fallback to push v2s1? |
Yes. It would be very convenient if we could determine v2 support without having to create and try to push v2, I am not sure whether that is possible. |
Yeah, that is the “convert and try” method which I’d like to avoid :) |
can it work with this "convert and try" though? |
Sure, it is software, we can build anything we can specify. But with the increasing number of formats (schema1, schema2, OCI, perhaps even native Docker tar exposed to |
#88 implements the “convert and try” method. At least with the OpenShift |
dockerImageDestination.SupportedManifestMIMETypes
returns a hard-coded value; if the destination registry does not in fact support schema 2, we would still attempt to upload this.This incorrect information will break any manifest conversion we might attempt.
The text was updated successfully, but these errors were encountered: