manifest.GuessMIMEType(): recognize self-described OCI manifests #1419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtrmac
reviewed
Nov 29, 2021
There was a problem hiding this comment.
Please update also the comment below, something like mtrmac@665a421 .
(I’m not sure when I’ll finish that wider work, so merging this part now makes perfect sense.)
|
Oof, I need to add tests for this. |
nalind
force-pushed
the
guess-manifests
branch
from
3adb4be
to
1b8230e
Compare
Newer versions of the OCI spec include the mediaType field in image manifests and image indexes, and if they include them, save ourselves some work by using that information. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
nalind
force-pushed
the
guess-manifests
branch
from
1b8230e
to
886a2ed
Compare
|
Added "nomime" variants to the existing OCI test cases for |
mtrmac
reviewed
Nov 29, 2021
|
LGTM |
mtrmac
added a commit
to mtrmac/skopeo
that referenced
this pull request
Dec 2, 2021
... to a version past 1.0.2, just to keep various dependency checkers happy. > go get github.com/opencontainers/image-spec@v1.0.2-0.20211123152302-43a7dee1ec31 The commit is intended to match containers/image#1419 to minimize churn. NOTE: This is NOT a fix for CVE-2021-41190 / GHSA-77vh-xpmg-72qh , that was fixed in Skopeo 1.5.2. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer versions of the OCI spec include the mediaType field in image manifests and image indexes, and if they include them, save ourselves some work by using that information.