Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more description to the containers/image library #150

Merged
merged 1 commit into from
Nov 4, 2016

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Nov 4, 2016

Close #146

@rhatdan
Copy link
Member Author

rhatdan commented Nov 4, 2016

@runcom PTAL

@rhatdan
Copy link
Member Author

rhatdan commented Nov 4, 2016

@HuKeping @cyphar PTAL

@@ -1,7 +1,26 @@
[![GoDoc](https://godoc.org/github.com/containers/image?status.svg)](https://godoc.org/github.com/containers/image) [![Build Status](https://travis-ci.org/containers/image.svg?branch=master)](https://travis-ci.org/containers/image)
=

`image` is a set of Go libraries aimed at working in various way with containers' images.
`image` is a set of Go libraries aimed at working in various way with containers' images and container image registries.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to wrap this line too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No I will up wrap all lines.

`image` is a set of Go libraries aimed at working in various way with containers' images and container image registries.

The containers/image library allows application to pull and push images from
container image registries, like a upstream docker registry. It also implements
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo s/a upstream/the upstream/g

"simple image signing".

The containers/image library also allows you to inspect a repository on a
container registry without pulling down the image. This means it fetch the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/fetch/fetches/ ?

@cyphar
Copy link
Contributor

cyphar commented Nov 4, 2016

Nits aside, the actual description LGTM.

you to copy container images between various registries, possibly converting
them as necessary, and to sign and verify images.

The https://github.com/projectatomic/skopeo tool uses the containers/image
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[skopeo](https://github.com/projectatomic/skopeo)

@runcom
Copy link
Member

runcom commented Nov 4, 2016

small nits, LGTM otherwise

@rhatdan
Copy link
Member Author

rhatdan commented Nov 4, 2016

All fixed.

@runcom
Copy link
Member

runcom commented Nov 4, 2016

👍 will merge after tests

Approved with PullApprove

@runcom
Copy link
Member

runcom commented Nov 4, 2016

@rhatdan you need to sign your commit I guess

@rhatdan rhatdan force-pushed the master branch 2 times, most recently from 0e178be to 74b1e47 Compare November 4, 2016 12:34
@runcom
Copy link
Member

runcom commented Nov 4, 2016

Travis is busted, I'll fix it

@@ -1,7 +1,15 @@
[![GoDoc](https://godoc.org/github.com/containers/image?status.svg)](https://godoc.org/github.com/containers/image) [![Build Status](https://travis-ci.org/containers/image.svg?branch=master)](https://travis-ci.org/containers/image)
=

`image` is a set of Go libraries aimed at working in various way with containers' images.
`image` is a set of Go libraries aimed at working in various way with containers' images and container image registries.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rhatdan Travis is failing because it detected that at the end of this line there's a whitespace (just after the final dot), could you remove it and re-push?

@runcom
Copy link
Member

runcom commented Nov 4, 2016

Seems like Travis didn't run make .gitvalidation for a long time and now we have all these failures - really weird...

@runcom
Copy link
Member

runcom commented Nov 4, 2016

@rhatdan one more thing, this needs a rebase (maybe that's why travis keeps failing)

@runcom
Copy link
Member

runcom commented Nov 4, 2016

@rhatdan seems like #153 (which is this PR but it's rebased) has CI fixed (wrt git validation). So, yes, just rebase this and should be good to go.

Signed-off-by: Dan Walsh <dwalsh@redhat.com>
@runcom
Copy link
Member

runcom commented Nov 4, 2016

thx Dan, let's get this in

@runcom runcom merged commit d5fbbe9 into containers:master Nov 4, 2016
@HuKeping
Copy link

HuKeping commented Nov 5, 2016

Awesome @rhatdan !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants