-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more description to the containers/image library #150
Conversation
@runcom PTAL |
@@ -1,7 +1,26 @@ | |||
[![GoDoc](https://godoc.org/github.com/containers/image?status.svg)](https://godoc.org/github.com/containers/image) [![Build Status](https://travis-ci.org/containers/image.svg?branch=master)](https://travis-ci.org/containers/image) | |||
= | |||
|
|||
`image` is a set of Go libraries aimed at working in various way with containers' images. | |||
`image` is a set of Go libraries aimed at working in various way with containers' images and container image registries. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean to wrap this line too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No I will up wrap all lines.
`image` is a set of Go libraries aimed at working in various way with containers' images and container image registries. | ||
|
||
The containers/image library allows application to pull and push images from | ||
container image registries, like a upstream docker registry. It also implements |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo s/a upstream/the upstream/g
"simple image signing". | ||
|
||
The containers/image library also allows you to inspect a repository on a | ||
container registry without pulling down the image. This means it fetch the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/fetch/fetches/ ?
Nits aside, the actual description LGTM. |
you to copy container images between various registries, possibly converting | ||
them as necessary, and to sign and verify images. | ||
|
||
The https://github.com/projectatomic/skopeo tool uses the containers/image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[skopeo](https://github.com/projectatomic/skopeo)
small nits, LGTM otherwise |
All fixed. |
@rhatdan you need to sign your commit I guess |
0e178be
to
74b1e47
Compare
Travis is busted, I'll fix it |
@@ -1,7 +1,15 @@ | |||
[![GoDoc](https://godoc.org/github.com/containers/image?status.svg)](https://godoc.org/github.com/containers/image) [![Build Status](https://travis-ci.org/containers/image.svg?branch=master)](https://travis-ci.org/containers/image) | |||
= | |||
|
|||
`image` is a set of Go libraries aimed at working in various way with containers' images. | |||
`image` is a set of Go libraries aimed at working in various way with containers' images and container image registries. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rhatdan Travis is failing because it detected that at the end of this line there's a whitespace (just after the final dot), could you remove it and re-push?
Seems like Travis didn't run make .gitvalidation for a long time and now we have all these failures - really weird... |
@rhatdan one more thing, this needs a rebase (maybe that's why travis keeps failing) |
Signed-off-by: Dan Walsh <dwalsh@redhat.com>
thx Dan, let's get this in |
Awesome @rhatdan ! |
Close #146