Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to benefit from Go 1.17 #1571

Merged
merged 3 commits into from
Jun 14, 2022
Merged

Update to benefit from Go 1.17 #1571

merged 3 commits into from
Jun 14, 2022

Commits on Jun 14, 2022

  1. Update go.mod to Go 1.17 

    > go mod tidy -go=1.17

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
    @mtrmac
    mtrmac committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    f9f909d View commit details
    Browse the repository at this point in the history

  2. Stop using net/tls.Config.PreferServerCipherSuites 

    As of Go 1.17 it is deprecated and ignored.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
    @mtrmac
    mtrmac committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    225404e View commit details
    Browse the repository at this point in the history

  3. Use testing.T.Setenv instead of os.Setenv in tests 

    ... to simplify and benefit from Go 1.17.

In some cases, wrap tests in testing.T.Run() to decrease
the scope, or to make the relationship between the test and the
cleanup clearer.  In some cases it's still a bit awkward
because there is no testing.T.Unsetenv, but still worth it.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
    @mtrmac
    mtrmac committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    a56436c View commit details
    Browse the repository at this point in the history