image: schema2: add no-conversion for schema2 configs #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if a Docker Schema2 configuration was being "converted" to a Schema2 configuration then it would cause errors even though the conversion should be a simple copy. Fix this by just adding a dummy conversion (just like in schema1). Signed-off-by: Aleksa Sarai <asarai@suse.de>
This was referenced Nov 25, 2016
|
Thanks, but this really should do a proper conversion instead, as you have discovered in #171. The schema1 case is not really a template to follow; Docker treats both the signed and unsigned MIME types completely equivalently (e.g. requiring the presence of a signature); OTOH schema2/OCI really are different. Currently, schema2 rejects a conversion to itself because it very likely means a confused caller. Philosophically this is of course debatable, a silent no-op also makes some sense, but OCI→schema2 does need to really convert. |
giuseppe
pushed a commit
to giuseppe/image
that referenced
this pull request
Jan 24, 2017
Makefile cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if a Docker Schema2 configuration was being "converted" to a
Schema2 configuration then it would cause errors even though the
conversion should be a simple copy. Fix this by just adding a dummy
conversion (just like in schema1).
Fixes: #168
Signed-off-by: Aleksa Sarai asarai@suse.de