Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies of docker/docker #2110

Merged
merged 1 commit into from Sep 6, 2023

Conversation

mtrmac
Copy link
Collaborator

@mtrmac mtrmac commented Sep 6, 2023

docker/docker maintains its dependencies in vendor.mod, not go.mod, so automated tooling doesn't know to follow that.

Do that manually:

go get gotest.tools/v3@v3.5.0

This is actually called only in tests, so it does not change the built binary. But update to make sure the dependency tree is not behind what docker/docker is testing with.

#2109 updated docker/docker itself.

docker/docker maintains its dependencies in vendor.mod,
not go.mod, so automated tooling doesn't know to follow that.

Do that manually:

> go get gotest.tools/v3@v3.5.0

This is actually _called_ only in tests, so it does not
change the built binary. But update to make sure the dependency
tree is not behind what docker/docker is testing with.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtrmac mtrmac merged commit 8be6291 into containers:main Sep 6, 2023
9 checks passed
@mtrmac mtrmac deleted the docker-recursive-deps branch September 6, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants