Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow matching of compressed blobs converted on the fly to zstd:chunked #2478

Merged
merged 3 commits into from
Jul 11, 2024

Conversation

mtrmac
Copy link
Collaborator

@mtrmac mtrmac commented Jul 8, 2024

… per discussion in containers/storage#2001 .

@mtrmac
Copy link
Collaborator Author

mtrmac commented Jul 8, 2024

Warning: absolutely untested

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
…gest

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
…created on-the-fly

This will allow matching the compressed blob in tryReusingBlobAsPending.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
@mtrmac mtrmac changed the title WIP: Allow matching of compressed blobs converted on the fly to zstd:chunked Allow matching of compressed blobs converted on the fly to zstd:chunked Jul 10, 2024
@mtrmac
Copy link
Collaborator Author

mtrmac commented Jul 10, 2024

@giuseppe PTAL, now on top of the merged c/storage feature.

@mtrmac mtrmac marked this pull request as ready for review July 10, 2024 14:49
@mtrmac
Copy link
Collaborator Author

mtrmac commented Jul 10, 2024

(I have previously tested the this change as part of #2321 )

@mtrmac mtrmac added the kind/feature A request for, or a PR adding, new functionality label Jul 10, 2024
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan
Copy link
Member

rhatdan commented Jul 11, 2024

LGTM

@rhatdan rhatdan merged commit 39cd14d into containers:main Jul 11, 2024
10 checks passed
@mtrmac mtrmac deleted the chunked-convert-match branch July 11, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature A request for, or a PR adding, new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants