Make the libostree dependency optional #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful primarily so that we can use build tags to remove transports from transports/alltransports, while giving users more hints about what to do instead of a bland “unknown transport”. Tests can also use this instead of their own mocks. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
…pendency optional If this tag is defined, transports/alltransports registers a stub instead of the real package. Also updates README, adding the ostree-devel dependency to the dnf command and restructuring it to have a list of build tags. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
|
@mtrmac thanks, LGTM |
|
LGTM |
|
Can you give me a description of how to mangle the commit so it will apply to skopeo? I am having difficulty with that, but it may be because I'm doing it incorrectly. |
|
👍 @williamh Thanks for testing this, and I’m sorry for not getting back to you with something easier to test. |
This was referenced Jun 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
containers_image_ostree_stubbuild tag to allow making the libostree dependency optional. See the individual commit messages for more details.@williamh , could you please try applying this PR to the vendored copy of containers/image in skopeo, and then building skopeo with
make binary-local BUILDTAGS=containers_image_ostree_stub?@giuseppe FYI