Support v3 signature packets in mechanism_openpgp #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are handled similarly to the more common V4 signature packets, except that MessageDetails.SignatureV3 is set instead of MessageDetails.Signature, and they don’t support expiration. Bulk of the commit is adding tests which use V3 signature packets. I have regenerated unknown-key.signature because it was generated using a temporary key created just for that purpose, and the test is simpler when fixtures for both packet variants to use the same key. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
|
LGTM (this code is already part of OpenShift 3.6 :-) |
|
LGTM |
|
LGTM |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are handled similarly to the more common V4 signature packets, except that
MessageDetails.SignatureV3is set instead ofMessageDetails.Signature, and they don’t support expiration.Bulk of the commit is adding tests which use V3 signature packets.
I have regenerated
unknown-key.signaturebecause it was generated using a temporary key created just for that purpose, and the test is simpler when fixtures for both packet variants to use the same key.Cc: @mfojtik