alltransports: ostree is linux only

[vbatts]

Signed-off-by: Vincent Batts vbatts@hashbangbash.com

[mtrmac]

Please update ostree_stub.go in the same directory as well.

[vbatts]

updated PTAL

…

On Tue, Jan 23, 2018 at 10:43 AM, Miloslav Trmač ***@***.***> wrote: Please update ostree_stub.go in the same directory as well. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#408 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEF6UKAqeqlFhtuyroPtyZCd1AITh2Jks5tNf4qgaJpZM4RptHV> .

[vbatts]

let me just double check that a comma here means AND

[vbatts]

yea https://golang.org/pkg/go/build/#hdr-Build_Constraints carry on

[mtrmac]

The idea is that the stub is compiled in exactly when the true registration isn’t, so shouldn’t the negation of (!containers_image_ostree_stub and linux) be (containers_image_ostree_stub or !linux)?

[vbatts]

@mtrmac yea, i think you're right. Updated. PTAL

[vbatts]

@mtrmac off-topic of this PR, but similar needs to be done between ./signature/mechanism_gpgme.go and ./signature/mechanism_openpgp.go but there is something more tricky in that arrangement, including undefined functions like:

vendor/github.com/containers/image/signature/mechanism.go:48:9: undefined: newGPGSigningMechanismInDirectory
vendor/github.com/containers/image/signature/mechanism.go:56:9: undefined: newEphemeralGPGSigningMechanism

[mtrmac]

👍 Thanks!

[mtrmac]

@mtrmac off-topic of this PR, but similar needs to be done between ./signature/mechanism_gpgme.go and ./signature/mechanism_openpgp.go

Not exactly the same thing; GpgME can be installed on macOS (and we do use it there by default). Maybe we might want to disable GpgME on Windows, or autodetect its availability.

but there is something more tricky in that arrangement, including undefined functions like:

vendor/github.com/containers/image/signature/mechanism.go:48:9: undefined: newGPGSigningMechanismInDirectory
vendor/github.com/containers/image/signature/mechanism.go:56:9: undefined: newEphemeralGPGSigningMechanism

That looks like you have disabled both of the mechanisms, which is not supported; at least one of them must be enabled. (The openpgp one does not require cgo, so it should be an acceptable universal fallback.)

[vbatts]

i can't figure out how to get the mechanism to just choose openpgp when building on windows. :-\

…

On Mon, Jan 29, 2018 at 10:49 AM, Miloslav Trmač ***@***.***> wrote: @mtrmac <https://github.com/mtrmac> off-topic of this PR, but similar needs to be done between ./signature/mechanism_gpgme.go and ./signature/mechanism_openpgp.go Not exactly the same thing; GpgME can be installed on macOS (and we do use it there by default). Maybe we might want to disable GpgME on Windows, or autodetect its availability. but there is something more tricky in that arrangement, including undefined functions like: vendor/github.com/containers/image/signature/mechanism.go:48:9: undefined: newGPGSigningMechanismInDirectory vendor/github.com/containers/image/signature/mechanism.go:56:9: undefined: newEphemeralGPGSigningMechanism That looks like you have disabled both of the mechanisms, which is not supported; at least one of them must be enabled. (The openpgp one does not require cgo, so it should be an acceptable universal fallback.) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#408 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEF6bKeJe8xeagzVzhHjhgI32VGFnq6ks5tPeiGgaJpZM4RptHV> .

[vbatts]

updated. PTAL

[rhatdan]

LGTM

[mtrmac]

@runcom ping

[vbatts]

@runcom review please?

[runcom]

lgtm