Remove .tar extension from blob and config file names #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense overall, but this is an incompatible change, so it should increase the version number. Can you prepare a parallel PR to fix the skopeo tests, please? (Highlighting: This will break existing automated consumers of the |
|
LGTM |
|
FYI Buildah uses the dir: format pretty heavily in its bats tests. |
|
Change LGTM, Travis is unhappy and we'll need to roll into the other projects. |
The config file was being saved as digest.tar for the directory transport. This is misleading as the config file is not a tar archive. Dropped the .tar extension from all files now, including blobs. The user can use a tool like file to determine the format of the files in the directory. Signed-off-by: umohnani8 <umohnani@redhat.com>
|
Increased the version number to 1.1 from 1.0 |
|
LGTM pending tests. Thanks! |
|
@runcom PTAL |
|
@umohnani8 Why is test blowing up? |
|
LGTM |
|
@umohnani8 go ahead and fix containers/skopeo#479 |
asmacdo
added a commit
to asmacdo/pulp_docker
that referenced
this pull request
Jun 4, 2018
skopeo removed the expectation that the file ends in .tar, which is not consistent with the tar spec. containers/image#419 fixes: #3705
asmacdo
added a commit
to asmacdo/pulp_docker
that referenced
this pull request
Jun 4, 2018
skopeo removed the expectation that the file ends in .tar, which is not consistent with the tar spec. containers/image#419 fixes: #3703
asmacdo
added a commit
to asmacdo/pulp_docker
that referenced
this pull request
Jun 6, 2018
Adds comparators for a new class Version which represents a skopeo directory transport version. This will allow us to easily support future changes. containers/image#419 fixes: #3703 [WIP] Alternative: read version file Version comparisons, done right Version comparator and unittests
asmacdo
added a commit
to asmacdo/pulp_docker
that referenced
this pull request
Jun 11, 2018
Adds comparators for a new class Version which represents a skopeo directory transport version. This will allow us to easily support future changes. containers/image#419 fixes: #3703 [WIP] Alternative: read version file Version comparisons, done right Version comparator and unittests
asmacdo
added a commit
to asmacdo/pulp_docker
that referenced
this pull request
Jun 12, 2018
Adds comparators for a new class Version which represents a skopeo directory transport version. This will allow us to easily support future changes. containers/image#419 fixes: #3703
asmacdo
added a commit
to asmacdo/pulp_docker
that referenced
this pull request
Jun 12, 2018
Adds comparators for a new class Version which represents a skopeo directory transport version. This will allow us to easily support future changes. containers/image#419 fixes: #3703
asmacdo
added a commit
to asmacdo/pulp_docker
that referenced
this pull request
Jun 12, 2018
Adds comparators for a new class Version which represents a skopeo directory transport version. This will allow us to easily support future changes. containers/image#419 fixes: #3703
asmacdo
added a commit
to asmacdo/pulp_docker
that referenced
this pull request
Jun 18, 2018
Adds comparators for a new class Version which represents a skopeo directory transport version. This will allow us to easily support future changes. containers/image#419 fixes: #3703
pcreech
pushed a commit
to pulp/pulp_docker
that referenced
this pull request
Jun 18, 2018
Adds comparators for a new class Version which represents a skopeo directory transport version. This will allow us to easily support future changes. containers/image#419 fixes: #3703
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The config file was being saved as digest.tar for the directory transport.
This is misleading as the config file is not a tar archive.
Dropped the .tar extension from all files now, including blobs.
The user can use a tool like file to determine the format of the files in the directory.
Fixes issue containers/buildah#481
Signed-off-by: umohnani8 umohnani@redhat.com