Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intial authfile man page #821

Merged
merged 1 commit into from
Mar 4, 2020
Merged

Intial authfile man page #821

merged 1 commit into from
Mar 4, 2020

Conversation

TomSweeneyRedHat
Copy link
Member

The initial man page for the authfile used by
the container tools.

Fixes: containers/podman#4359

Signed-off-by: TomSweeneyRedHat tsweeney@redhat.com

@TomSweeneyRedHat
Copy link
Member Author

Will clean up white space errors that gitvalidate is not happy about after the first round of comments.

@rhatdan
Copy link
Member

rhatdan commented Feb 19, 2020

@QiWang19 PTAL


## FORMAT

The auth.json file is stores encrypted authentication information for the
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no is?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You is correct! Thanks!

@QiWang19
Copy link
Collaborator

LGTM

"auths": {
"localhost:5001": {}
},
"credsStore": "secretservice"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@QiWang19 @mtrmac Do we support credsStore?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. I see the code can only parse "credHelpers":{}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we should not document it here, until we get containers/image to support credStore.

@mtrmac
Copy link
Collaborator

mtrmac commented Feb 20, 2020

A very weak suggestion: do we want to commit to the format, or just to say “use an API”? Given that we have decided to be compatible, documenting the format as implemented is I suppose good and the downside of inability to change the format is negligible; still, throwing this out here to consider.

@rhatdan
Copy link
Member

rhatdan commented Feb 21, 2020

I would just document what we have now. Would be difficult to remove support now, but we could extend it in the future.

@TomSweeneyRedHat
Copy link
Member Author

OK as there's a number of questions on how credential-helpers/cred-stores are working with the auth file ATM, I've removed the info from that. We need to take a look at that and then update this file after it's sorted out.

Unless there are strong objections, I'd like to at least get this in for now.

@rhatdan
Copy link
Member

rhatdan commented Feb 21, 2020

LGTM, will merge once the tests pass.

@TomSweeneyRedHat
Copy link
Member Author

I needed to rebase and have repushed without changes to the file.

@rhatdan
Copy link
Member

rhatdan commented Mar 3, 2020

@vrothberg PTAL

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit regarding the name, other than that LGTM.

docs/containers-authfile.5.md Outdated Show resolved Hide resolved
The auth.json file stores encrypted authentication information for the
user to container image registries. The file can have zero to many entries and
is created by a `login` command from a container tool such as `podman login` or
`buildah login`. Each entry includes the name of the registry and then an auth
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow related: I'd love there to be a skopeo login :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@QiWang19 Could you add this to your list of Things to Do. Add skopoe login/logout.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The initial man page for the authfile used by
the container tools.

Fixes: containers/podman#4359

Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
@TomSweeneyRedHat
Copy link
Member Author

I've renamed the file inside and out (thx @vrothberg !) and have repushed.

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @TomSweeneyRedHat

@rhatdan
Copy link
Member

rhatdan commented Mar 4, 2020

LGTM

@rhatdan rhatdan merged commit fe9e174 into containers:master Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document the authfile contents, most likely in podman login.
5 participants