virtio/snd: import virtio-snd from vhost-user-sound #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
slp
commented
May 10, 2024
slp
commented
It's sometimes convenient to carry a Desciptor raw values around. Intead of forcing devices to implement their our structure for carrying that info, let's expose Descriptor and add a method to derive a Descriptor from a DescriptorChain. Signed-off-by: Sergio Lopez <slp@redhat.com>
Import a virtio-snd device from vhost-user-sound, trying to preserve as much as possible of the original semantics to we can eventually consume that crate if transitions to expose the device personality indenendently. Signed-off-by: Sergio Lopez <slp@redhat.com>
Add SND flag to easily request enabling virtio-snd while building the package. Signed-off-by: Sergio Lopez <slp@redhat.com>
This version includes, among other improvements and bug fixes, an extension of the API for enabling a virtio-snd device, meaning we need to bump the minor version. Signed-off-by: Sergio Lopez <slp@redhat.com>
tylerfanelli
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.