Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE] Image mount #4209

Closed
wants to merge 2 commits into from
Closed

[DO NOT MERGE] Image mount #4209

wants to merge 2 commits into from

Conversation

kunalkushwaha
Copy link
Collaborator

Mount image option added to podman mount.
This PR depends on containers/storage#438

Creating PR in parallel to discuss implementation.

Fixes: #1433

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kunalkushwaha
To complete the pull request process, please assign baude
You can assign the PR to them by writing /assign @baude in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L labels Oct 7, 2019
kunalkushwaha and others added 2 commits October 7, 2019 17:26
@kunalkushwaha
mount and umount function for image added.
4b38c86 
MountImage and UnmountImage functions added to mount
image roots without any association with container.
MountImage mounts in ReadOnly mode only.

Signed-off-by: Kunal Kushwaha <kunal.kushwaha@gmail.com>
@kunalkushwaha
mount/umount image option added
a252e81 
image mount/umount option added to libpod cli.
varlink for umount is not yet implemented.
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 7, 2019
@openshift-ci-robot
Copy link
Collaborator

@kunalkushwaha: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/images a252e81 link /test images

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kunalkushwaha
Copy link
Collaborator Author

  • while mounting single layer image, it returns success, but mount is unsuccessful.
    -- is anything missing in MountImage implementation or Need be handled in layer.Mount() ?

@rh-atomic-bot
Copy link
Collaborator

☔ The latest upstream changes (presumably #4310) made this pull request unmergeable. Please resolve the merge conflicts.

@kunalkushwaha kunalkushwaha mentioned this pull request Nov 6, 2019
Closed
@github-actions
Copy link

This pull request had no activity for 30 days. In the absence of activity or the "do-not-close" label, the pull request will be automatically closed within 7 days.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 29, 2019
@openshift-ci-robot
Copy link
Collaborator

@kunalkushwaha: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhatdan
Copy link
Member

rhatdan commented Nov 29, 2019

@kunalkushwaha Needs a rebase.

@github-actions github-actions bot closed this Dec 7, 2019
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jwhonce jwhonce Awaiting requested review from jwhonce

@mheon mheon Awaiting requested review from mheon

Assignees
No one assigned
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. stale-pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mount image filesystem
4 participants
@kunalkushwaha @openshift-ci-robot @rh-atomic-bot @rhatdan