Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apiv2: Image filtering and fixup docs #5236

Merged
merged 2 commits into from
Feb 21, 2020
Merged

apiv2: Image filtering and fixup docs #5236

merged 2 commits into from
Feb 21, 2020

Conversation

marusak
Copy link
Contributor

@marusak marusak commented Feb 17, 2020

No description provided.

@marusak
apiv2: Enable filtering images by ID
d08e0c7 
It is more practical for API usage and also it is more in sync how
filtering of containers works.

Signed-off-by: Matej Marusak <mmarusak@redhat.com>
@marusak
apiv2: Fixup /containers/json filters documentation
b6e0692 
Mention what is the input format plus put literals into quotation marks
for better readability (plus it seems that some tags were not rendered).

Signed-off-by: Matej Marusak <mmarusak@redhat.com>
@marusak marusak requested review from baude and removed request for jwhonce and rhatdan February 17, 2020 17:59
@openshift-ci-robot
Copy link
Collaborator

Hi @marusak. Thanks for your PR.

I'm waiting for a containers member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M labels Feb 17, 2020
@jwhonce
Copy link
Member

jwhonce commented Feb 17, 2020 •
edited
Loading

LGTM
/ok-to-test

@rhatdan
Copy link
Member

rhatdan commented Feb 17, 2020

/lgtm
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 17, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2020
@marusak
Copy link
Contributor Author

marusak commented Feb 20, 2020

Not all tests are green - is this issue with these changes and is it blocking on me?

@TomSweeneyRedHat
Copy link
Member

@marusak I don't believe the issue lies within your changes. I think it's just the CI not behaving as it should. I've just restarted the failing test, it looked to be a network hiccup.

@rhatdan
Copy link
Member

rhatdan commented Feb 21, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 21, 2020
@rhatdan
Copy link
Member

rhatdan commented Feb 21, 2020

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marusak, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2020
@openshift-merge-robot openshift-merge-robot merged commit a554e97 into containers:master Feb 21, 2020
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@baude baude Awaiting requested review from baude

Assignees

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@marusak @openshift-ci-robot @jwhonce @rhatdan @TomSweeneyRedHat @openshift-merge-robot