Skip to content

Commit

Permalink
chore: drop patternfly
Browse files Browse the repository at this point in the history
also remove the overrides that were done on top of patternfly

change default color of text to be white and bring font-awesome font/css
before it was being provided through patternfly but as it is removed it was not there anymore

fixes #1617
fixes #4319

Signed-off-by: Florent Benoit <fbenoit@redhat.com>
  • Loading branch information
benoitf committed Nov 14, 2023
1 parent 8979f5b commit 6bee813
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 40 deletions.
4 changes: 2 additions & 2 deletions packages/renderer/index.html
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
<!DOCTYPE html>
<html class="pf-theme-dark fixed" lang="en">
<html class="fixed" lang="en">
<head>
<meta charset="UTF-8" />
<link rel="icon" href="/favicon.ico" />
<meta name="viewport" content="width=device-width, height=device-height, initial-scale=1.0" />
<title>Podman Desktop</title>
</head>
<body class="overflow-hidden">
<body class="overflow-hidden text-white">
<div id="app"></div>
<script type="module" src="/src/main.ts"></script>
</body>
Expand Down
1 change: 1 addition & 0 deletions packages/renderer/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
"check": "svelte-check --tsconfig ./tsconfig.json"
},
"devDependencies": {
"@fortawesome/fontawesome-free": "^6.4.2",
"@fortawesome/free-brands-svg-icons": "^6.4.2",
"@fortawesome/free-solid-svg-icons": "^6.4.2",
"@fortawesome/free-regular-svg-icons": "^6.4.2",
Expand Down
5 changes: 1 addition & 4 deletions packages/renderer/src/App.svelte
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
<script lang="ts">
import './app.css';
import '@patternfly/patternfly/patternfly.css';
import '@patternfly/patternfly/patternfly-addons.css';
import '@patternfly/patternfly/patternfly-theme-dark.css';
import './override.css';
import '@fortawesome/fontawesome-free/css/all.min.css';
import { router } from 'tinro';
import Route from './Route.svelte';
Expand Down
29 changes: 0 additions & 29 deletions packages/renderer/src/override.css

This file was deleted.

10 changes: 5 additions & 5 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2396,6 +2396,11 @@
resolved "https://registry.yarnpkg.com/@fortawesome/fontawesome-common-types/-/fontawesome-common-types-6.4.2.tgz#1766039cad33f8ad87f9467b98e0d18fbc8f01c5"
integrity sha512-1DgP7f+XQIJbLFCTX1V2QnxVmpLdKdzzo2k8EmvDOePfchaIGQ9eCHj2up3/jNEbZuBqel5OxiaOJf37TWauRA==

"@fortawesome/fontawesome-free@^6.4.2":
version "6.4.2"
resolved "https://registry.yarnpkg.com/@fortawesome/fontawesome-free/-/fontawesome-free-6.4.2.tgz#36b6a9cb5ffbecdf89815c94d0c0ffa489ac5ecb"
integrity sha512-m5cPn3e2+FDCOgi1mz0RexTUvvQibBebOUlUlW0+YrMjDTPkiJ6VTKukA1GRsvRw+12KyJndNjj0O4AgTxm2Pg==

"@fortawesome/fontawesome-svg-core@^6.4.2":
version "6.4.2"
resolved "https://registry.yarnpkg.com/@fortawesome/fontawesome-svg-core/-/fontawesome-svg-core-6.4.2.tgz#37f4507d5ec645c8b50df6db14eced32a6f9be09"
Expand Down Expand Up @@ -2908,11 +2913,6 @@
"@octokit/webhooks-types" "7.1.0"
aggregate-error "^3.1.0"

"@patternfly/patternfly@^4.224.5":
version "4.224.5"
resolved "https://registry.yarnpkg.com/@patternfly/patternfly/-/patternfly-4.224.5.tgz#ad704848ce7754fcd6ffc5dc349f17beb84168ce"
integrity sha512-io0huj+LCP5FgDZJDaLv1snxktTYs8iCFz/W1VDRneYoebNHLmGfQdF7Yn8bS6PF7qmN6oJKEBlq3AjmmE8vdA==

"@phenomnomnominal/tsquery@^5.0.0":
version "5.0.1"
resolved "https://registry.yarnpkg.com/@phenomnomnominal/tsquery/-/tsquery-5.0.1.tgz#a2a5abc89f92c01562a32806655817516653a388"
Expand Down

0 comments on commit 6bee813

Please sign in to comment.