-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design: Preferences Layout #183
Comments
Beginning with how the preferences/settings page should open, I have made a sketch in FIGJAM https://www.figma.com/file/FkfUo7A97j8TXWwonsOtSp/Preferences-section Essentially, when the user clicks on settings, a new page should be opened |
With regards to the configuration settings, I have made some sketches in FIGJAM on what I think they should look like. However, I am still unclear on the content that needs to be presented to the users. Some feedback on these sketches would be helpful: https://www.figma.com/file/b6wXhPl49jRI9aJJVtqkND/configuration-settings |
Thanks @gbengaoti ! The proposed layout approach works well! Question:
I think the next step would be to look at creating patterns that we can reuse across different sections. The proposed solution from @mairin with tiles for registries could be a nice option, but I'm worry it might not be applicable for all kinds of configurations and we may need simple list. As @mairin pointed out, it's going to be important to allow creating/editing without using a 3rd level of modal too. |
Thanks, Steven, the user preferences are currently called preferences on the main settings page but the label can be changed to make it clearer. Have you had a look at the configuration page, are you happy with the structure and the content of it? Please let me know Yes, unifying the UI of the application would be good |
Two inital options here.... top has a tree, bottom does not. I'm concerned about ordering... some of these seem more core than others - what I did in the tree one is pin the "Preferences" category to the top and the rest are in alphabetical order by top level name. I can't make out rhyme or reason for how the order of how they display in vscode so that wasn't much inspiration. |
I prefer option 1 but it may take more to implement About the way to update values, when is it done ? each time user change a character ? |
Visually I prefer 1 as well, my only worry is whether the two columns on the left will take up too much space on small screens (but maybe that's not an issue). My preference for most properties is to have them apply immediately. I wonder if we'll want a 'reset to default' on some? |
reset to default would be nice (we know which properties have default values) |
I had a Slack chat with someone asking about preferences redesign, and they preferred the first option as well. They suggested the second tree could be merged into the left nav - which is essentially where it is today. I'd second that, or say that with only ~8 prefs today we could fix the rest and defer the decision of whether to add nav directly onto the page. |
Awesome thanks for the feedback! Here's the points I'm taking away to think about:
|
I forgot to update with the new mockups! The changelog for these is basically in the last comment: #183 (comment) Opt 1 Main nav tree mergeOpt 2 separate treeI believe during the UX review meeting we had a preference for opt #1. |
Signed-off-by: lstocchi <lstocchi@redhat.com>
feat: refactor preferences tree (#183) Signed-off-by: lstocchi <lstocchi@redhat.com>
This is already implemented 😅 Closing!! |
Is your enhancement related to a problem? Please describe
The layout / styles and sections in the preferences need to be reworked.
![Capture d’écran 2022-06-09 à 10 35 50](https://user-images.githubusercontent.com/1636769/172809298-d22c44c4-8596-4a10-977c-86ec5949e4e9.png)
At the moment there are the following challenges:
Describe the solution you'd like
Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: