Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement new settings page #446

Closed
6 tasks done
benoitf opened this issue Sep 5, 2022 · 1 comment · Fixed by #878
Closed
6 tasks done

Implement new settings page #446

benoitf opened this issue Sep 5, 2022 · 1 comment · Fixed by #878
Assignees
@vzhukovs @cdrage
Labels
kind/feature 💡 Issue for requesting a new feature

Comments

@benoitf
Copy link
Collaborator

benoitf commented Sep 5, 2022 •
edited by slemeur
Loading

Is your feature request related to a problem? Please describe

Current preferences page has not a proper UI and UX

UI team worked on #183 and now we need to implement the design

Describe the solution you'd like

Describe alternatives you've considered

No response

Additional context

image

image

https://design.penpot.app/#/workspace/2da7f950-f6fb-11ec-a4ab-f940e3befd53/50915a10-f6fb-11ec-a4ab-f940e3befd53?page-id=d8551b60-2a06-11ed-a96f-b58aa3c68825
@benoitf benoitf added the kind/feature 💡 Issue for requesting a new feature label Sep 5, 2022
@benoitf benoitf changed the title Implements new settings page Implement new settings page Sep 5, 2022
@slemeur slemeur mentioned this issue Sep 12, 2022
Closed
@vzhukovs vzhukovs mentioned this issue Sep 28, 2022
Merged
@vzhukovs vzhukovs mentioned this issue Nov 2, 2022
Merged
@vzhukovs vzhukovs mentioned this issue Nov 9, 2022
Closed
cdrage added a commit to cdrage/podman-desktop that referenced this issue Nov 21, 2022
@cdrage
feat: add age and image column to container list
c93d62a 
### What does this PR do?

Added image column:

* Now that we have more space on the row thanks to the kebab menu, we can
now add more items to the row such as image, instead of having it beside
the name.
* Allows to eventually "sort" by image in the list in the future.

Added age column:

* We repeatedly say "... ago" in every row which is redundant.
* Changed to to "AGE" and created shorter output (`X seconds ago` is now
`Xs`).
* Allows for more space on the row.

### Screenshot/screencast of this PR

<!-- Please include a screenshot or a screencast explaining what is doing this PR -->

### What issues does this PR fix or reference?

<!-- Please include any related issue from Podman Desktop repository (or from another issue tracker).
-->

Closes containers#446

### How to test this PR?

<!-- Please explain steps to reproduce -->

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
@cdrage cdrage mentioned this issue Nov 21, 2022
Merged
cdrage added a commit to cdrage/podman-desktop that referenced this issue Nov 21, 2022
@cdrage
feat: add age and image column to container list
150c222 
### What does this PR do?

Added image column:

* Now that we have more space on the row thanks to the kebab menu, we can
now add more items to the row such as image, instead of having it beside
the name.
* Allows to eventually "sort" by image in the list in the future.

Added age column:

* We repeatedly say "... ago" in every row which is redundant.
* Changed to to "AGE" and created shorter output (`X seconds ago` is now
`Xs`).
* Allows for more space on the row.

### Screenshot/screencast of this PR

<!-- Please include a screenshot or a screencast explaining what is doing this PR -->

### What issues does this PR fix or reference?

<!-- Please include any related issue from Podman Desktop repository (or from another issue tracker).
-->

Closes containers#446

### How to test this PR?

<!-- Please explain steps to reproduce -->

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
cdrage added a commit to cdrage/podman-desktop that referenced this issue Nov 21, 2022
@cdrage
feat: add age and image column to container list
a83224f 
### What does this PR do?

Added image column:

* Now that we have more space on the row thanks to the kebab menu, we can
now add more items to the row such as image, instead of having it beside
the name.
* Allows to eventually "sort" by image in the list in the future.

Added age column:

* We repeatedly say "... ago" in every row which is redundant.
* Changed to to "AGE" and created shorter output (`X seconds ago` is now
`Xs`).
* Allows for more space on the row.

### Screenshot/screencast of this PR

<!-- Please include a screenshot or a screencast explaining what is doing this PR -->

### What issues does this PR fix or reference?

<!-- Please include any related issue from Podman Desktop repository (or from another issue tracker).
-->

Closes containers#446

### How to test this PR?

<!-- Please explain steps to reproduce -->

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
cdrage added a commit to cdrage/podman-desktop that referenced this issue Nov 21, 2022
@cdrage
feat: add age and image column to container list
7488ef6 
### What does this PR do?

Added image column:

* Now that we have more space on the row thanks to the kebab menu, we can
now add more items to the row such as image, instead of having it beside
the name.
* Allows to eventually "sort" by image in the list in the future.

Added age column:

* We repeatedly say "... ago" in every row which is redundant.
* Changed to to "AGE" and created shorter output (`X seconds ago` is now
`Xs`).
* Allows for more space on the row.

### Screenshot/screencast of this PR

<!-- Please include a screenshot or a screencast explaining what is doing this PR -->

### What issues does this PR fix or reference?

<!-- Please include any related issue from Podman Desktop repository (or from another issue tracker).
-->

Closes containers#446

### How to test this PR?

<!-- Please explain steps to reproduce -->

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
cdrage added a commit to cdrage/podman-desktop that referenced this issue Nov 21, 2022
@cdrage
feat: add age and image column to container list
e271e2f 
### What does this PR do?

Added image column:

* Now that we have more space on the row thanks to the kebab menu, we can
now add more items to the row such as image, instead of having it beside
the name.
* Allows to eventually "sort" by image in the list in the future.

Added age column:

* We repeatedly say "... ago" in every row which is redundant.
* Changed to to "AGE" and created shorter output (`X seconds ago` is now
`Xs`).
* Allows for more space on the row.

### Screenshot/screencast of this PR

<!-- Please include a screenshot or a screencast explaining what is doing this PR -->

### What issues does this PR fix or reference?

<!-- Please include any related issue from Podman Desktop repository (or from another issue tracker).
-->

Closes containers#446

### How to test this PR?

<!-- Please explain steps to reproduce -->

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
cdrage added a commit to cdrage/podman-desktop that referenced this issue Nov 22, 2022
@cdrage
feat: add age and image column to container list
d8984c5 
### What does this PR do?

Added image column:

* Now that we have more space on the row thanks to the kebab menu, we can
now add more items to the row such as image, instead of having it beside
the name.
* Allows to eventually "sort" by image in the list in the future.

Added age column:

* We repeatedly say "... ago" in every row which is redundant.
* Changed to to "AGE" and created shorter output (`X seconds ago` is now
`Xs`).
* Allows for more space on the row.

### Screenshot/screencast of this PR

<!-- Please include a screenshot or a screencast explaining what is doing this PR -->

### What issues does this PR fix or reference?

<!-- Please include any related issue from Podman Desktop repository (or from another issue tracker).
-->

Closes containers#446

### How to test this PR?

<!-- Please explain steps to reproduce -->

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
cdrage added a commit that referenced this issue Nov 22, 2022
@cdrage
feat: add age and image column to container list (#878)
4a84e50 
### What does this PR do?

Added image column:

* Now that we have more space on the row thanks to the kebab menu, we can
now add more items to the row such as image, instead of having it beside
the name.
* Allows to eventually "sort" by image in the list in the future.

Added age column:

* We repeatedly say "... ago" in every row which is redundant.
* Changed to to "AGE" and created shorter output (`X seconds ago` is now
`Xs`).
* Allows for more space on the row.

### Screenshot/screencast of this PR

<!-- Please include a screenshot or a screencast explaining what is doing this PR -->

### What issues does this PR fix or reference?

<!-- Please include any related issue from Podman Desktop repository (or from another issue tracker).
-->

Closes #446

### How to test this PR?

<!-- Please explain steps to reproduce -->

Signed-off-by: Charlie Drage <charlie@charliedrage.com>

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
@cdrage cdrage reopened this Nov 22, 2022
@benoitf
Copy link
Collaborator Author

benoitf commented Nov 23, 2022

closing this one, remaining task is on #895

@benoitf benoitf closed this as completed Nov 23, 2022
@benoitf benoitf mentioned this issue Dec 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vzhukovs vzhukovs

@cdrage cdrage

Labels
kind/feature 💡 Issue for requesting a new feature
Projects
Podman Desktop Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add age and image column to container list cdrage/podman-desktop
3 participants
@benoitf @vzhukovs @cdrage