Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow extensions to customize icons in container list (or image list, etc) #1899

Closed
benoitf opened this issue Mar 31, 2023 · 6 comments
Closed

allow extensions to customize icons in container list (or image list, etc) #1899

benoitf opened this issue Mar 31, 2023 · 6 comments
Assignees
@lstocchi
Labels
area/extensions 🧩 kind/enhancement ✨ Issue for requesting an improvement

Comments

@benoitf
Copy link
Collaborator

benoitf commented Mar 31, 2023

Is your enhancement related to a problem? Please describe

Kind cluster is contributing a container (the controller plane)

it should be possible to tell to Podman Desktop to draw this icon differently

Describe the solution you'd like

could be like a contributing option

where we could have:
name of the view like icons/containersList ,

  • the filter to apply on a container like using the when clause "io.x-k8s.kind.cluster" in containerLabelKeys
  • icon: "$(kind)

Describe alternatives you've considered

No response

Additional context

No response
@benoitf benoitf added the kind/enhancement ✨ Issue for requesting an improvement label Mar 31, 2023
@deboer-tim deboer-tim mentioned this issue Apr 5, 2023
Closed
@lstocchi lstocchi self-assigned this May 29, 2023
@afbjorklund
Copy link
Contributor

The label for the container from the minikube extension is called name.minikube.sigs.k8s.io

@benoitf
Copy link
Collaborator Author

benoitf commented Jun 13, 2023

pre-requisites is #1525

@afbjorklund

This comment was marked as outdated.

Sign in to view
lstocchi added a commit to lstocchi/podman-desktop that referenced this issue Jul 5, 2023
@lstocchi
allow extensions to customize icons (containers#1899)
e3f92f3 
Signed-off-by: lstocchi <lstocchi@redhat.com>
@lstocchi lstocchi mentioned this issue Jul 5, 2023
Merged
lstocchi added a commit to lstocchi/podman-desktop that referenced this issue Jul 6, 2023
@lstocchi
allow extensions to customize icons (containers#1899)
5c5db74 
Signed-off-by: lstocchi <lstocchi@redhat.com>
lstocchi added a commit to lstocchi/podman-desktop that referenced this issue Jul 6, 2023
@lstocchi
allow extensions to customize icons (containers#1899)
455ec94 
Signed-off-by: lstocchi <lstocchi@redhat.com>
lstocchi added a commit to lstocchi/podman-desktop that referenced this issue Jul 6, 2023
@lstocchi
feat: allow extensions to customize icons (containers#1899)
694c5a1 
Signed-off-by: lstocchi <lstocchi@redhat.com>
@lstocchi lstocchi mentioned this issue Jul 6, 2023
Merged
lstocchi added a commit to lstocchi/podman-desktop that referenced this issue Jul 10, 2023
@lstocchi
feat: allow extensions to customize icons (containers#1899)
251bc6a 
Signed-off-by: lstocchi <lstocchi@redhat.com>
lstocchi added a commit to lstocchi/podman-desktop that referenced this issue Jul 11, 2023
@lstocchi
feat: allow extensions to customize icons (containers#1899)
396e4bf 
Signed-off-by: lstocchi <lstocchi@redhat.com>
lstocchi added a commit to lstocchi/podman-desktop that referenced this issue Jul 18, 2023
@lstocchi
feat: allow extensions to customize icons (containers#1899)
8318606 
Signed-off-by: lstocchi <lstocchi@redhat.com>
lstocchi added a commit to lstocchi/podman-desktop that referenced this issue Jul 20, 2023
@lstocchi
feat: allow extensions to customize icons (containers#1899)
7887bbb 
Signed-off-by: lstocchi <lstocchi@redhat.com>
lstocchi added a commit that referenced this issue Jul 21, 2023
@lstocchi
feat: allow extensions to customize icons (#1899) (#3131)
1ebe4c7 
* feat: allow extensions to customize icons (#1899)

Signed-off-by: lstocchi <lstocchi@redhat.com>

* fix: keep storage to server and move evaluation to renderer

Signed-off-by: lstocchi <lstocchi@redhat.com>

* fix: clean and add tests

Signed-off-by: lstocchi <lstocchi@redhat.com>

* fix: rename file and fix function signature

Signed-off-by: lstocchi <lstocchi@redhat.com>

* fix: move contextKeyValue type

Signed-off-by: lstocchi <lstocchi@redhat.com>

* fix: clean after messed rebase

Signed-off-by: lstocchi <lstocchi@redhat.com>

* fix: replace icon and refactor

Signed-off-by: lstocchi <lstocchi@redhat.com>

* chore: replace icon with one with margin

Signed-off-by: lstocchi <lstocchi@redhat.com>

---------

Signed-off-by: lstocchi <lstocchi@redhat.com>
@lstocchi
Copy link
Contributor

@benoitf in the title you were mentioning image list as well. Do you want to add support for that view now? Or we close this issue and we work on the image list when there is something to customize?

@benoitf
Copy link
Collaborator Author

benoitf commented Jul 25, 2023

we can close the issue for now
Thanks @lstocchi

@lstocchi
Copy link
Contributor

Closing. #3131 resolves this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lstocchi lstocchi

Labels
area/extensions 🧩 kind/enhancement ✨ Issue for requesting an improvement
Projects
Podman Desktop Planning
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@benoitf @afbjorklund @lstocchi @podman-desktop-bot