fix: replace backslash with slash so to support rendering on Windows (#3120) #3122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lstocchi
requested review from
jeffmaury and
cdrage
and removed request for
a team
benoitf
reviewed
Jul 5, 2023
benoitf
approved these changes
Jul 5, 2023
…ontainers#3120) Signed-off-by: lstocchi <lstocchi@redhat.com>
benoitf
reviewed
Jul 5, 2023
| @@ -46,7 +46,7 @@ onMount(() => { | |||
| }); | |||
|
|
|||
| fontsToAdd.forEach(font => { | |||
| const src = font.src.map(l => `${toUrl(l.location)} format('${l.format}')`).join(', '); | |||
| const src = font.src.map(l => `${toUrl(l.browserURL)} format('${l.format}')`).join(', '); | |||
There was a problem hiding this comment.
maybe it means we wouldn't need the toUrl method ?
There was a problem hiding this comment.
I thought there was a reason to have url('file://${location.replace(/'/g, '%27')}') in the client. Do i move everything in the server?
There was a problem hiding this comment.
I think that now that we provide the field for the client on the server, we could do everything on the server side so client is dummy, just use the field
Signed-off-by: lstocchi <lstocchi@redhat.com>
|
@benoitf updated. Please give it another look |
benoitf
approved these changes
Jul 5, 2023
Signed-off-by: lstocchi <lstocchi@redhat.com>
|
thanks @lstocchi |
mairin
pushed a commit
to mairin/podman-desktop
that referenced
this pull request
Jul 7, 2023
…ontainers#3120) (containers#3122) * fix: replace backslash with slash so to support rendering on Windows (containers#3120) Signed-off-by: lstocchi <lstocchi@redhat.com> * generate whole browser url from server side Signed-off-by: lstocchi <lstocchi@redhat.com> * fix: lint warning Signed-off-by: lstocchi <lstocchi@redhat.com> --------- Signed-off-by: lstocchi <lstocchi@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR replaces backslashes with slashes when creating the url of a font style.
On Windows backslashes get removed and it results in a wrong url.
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
this fixes #3120
How to test this PR?
N/A
This is useful for #1899 to work