Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Font url not escaped correctly when retrieving the resource in Windows #3120

Closed
lstocchi opened this issue Jul 5, 2023 · 0 comments · Fixed by #3122
Closed

Font url not escaped correctly when retrieving the resource in Windows #3120

lstocchi opened this issue Jul 5, 2023 · 0 comments · Fixed by #3122
Assignees
@lstocchi
Labels
area/dashboard 📊 Concern the dashboard from Container Desktop kind/bug 🐞 Something isn't working

Comments

@lstocchi
Copy link
Contributor

lstocchi commented Jul 5, 2023

Bug description

On Windows the font url gets broken as the backslashes are removed during the rendering.
The font url that is received by the IconStyle component is correct
Something like C://blabla1\\blabla2\\blabla3
but then during rendering all backslashes are removed resulting in C://blabla1blabla2blabla3. Because the url is incorrect you only see an empty rectangle in the UI

icon_broken

Operating system

Windows 11

Installation Method

None

Version

next (development version)

Steps to reproduce

  1. make an extension contributes an icon on windows
  2. you should see an empty rectangle

Relevant log output

No response

Additional context

No response
@lstocchi lstocchi added the kind/bug 🐞 Something isn't working label Jul 5, 2023
@lstocchi lstocchi self-assigned this Jul 5, 2023
@lstocchi lstocchi changed the title Font url not escaped correctly when retrieving the resource Font url not escaped correctly when retrieving the resource in Windows Jul 5, 2023
lstocchi added a commit to lstocchi/podman-desktop that referenced this issue Jul 5, 2023
@lstocchi
fix: replace backslash with slash so to support rendering on Windows (c…
a176f7d 
…ontainers#3120)

Signed-off-by: lstocchi <lstocchi@redhat.com>
@lstocchi lstocchi mentioned this issue Jul 5, 2023
Merged
lstocchi added a commit to lstocchi/podman-desktop that referenced this issue Jul 5, 2023
@lstocchi
fix: replace backslash with slash so to support rendering on Windows (c…
75f769b 
…ontainers#3120)

Signed-off-by: lstocchi <lstocchi@redhat.com>
@benoitf benoitf added area/dashboard 📊 Concern the dashboard from Container Desktop and removed status/need-triage labels Jul 5, 2023
lstocchi added a commit to lstocchi/podman-desktop that referenced this issue Jul 5, 2023
@lstocchi
fix: replace backslash with slash so to support rendering on Windows (c…
f7bd10b 
…ontainers#3120)

Signed-off-by: lstocchi <lstocchi@redhat.com>
lstocchi added a commit to lstocchi/podman-desktop that referenced this issue Jul 5, 2023
@lstocchi
fix: replace backslash with slash so to support rendering on Windows (c…
56c29ce 
…ontainers#3120)

Signed-off-by: lstocchi <lstocchi@redhat.com>
lstocchi added a commit that referenced this issue Jul 6, 2023
@lstocchi
fix: replace backslash with slash so to support rendering on Windows (#…
314a8a6 
…3120) (#3122)

* fix: replace backslash with slash so to support rendering on Windows (#3120)

Signed-off-by: lstocchi <lstocchi@redhat.com>

* generate whole browser url from server side

Signed-off-by: lstocchi <lstocchi@redhat.com>

* fix: lint warning

Signed-off-by: lstocchi <lstocchi@redhat.com>

---------

Signed-off-by: lstocchi <lstocchi@redhat.com>
mairin pushed a commit to mairin/podman-desktop that referenced this issue Jul 7, 2023
@lstocchi @mairin
fix: replace backslash with slash so to support rendering on Windows (c…
525cea6 
…ontainers#3120) (containers#3122)

* fix: replace backslash with slash so to support rendering on Windows (containers#3120)

Signed-off-by: lstocchi <lstocchi@redhat.com>

* generate whole browser url from server side

Signed-off-by: lstocchi <lstocchi@redhat.com>

* fix: lint warning

Signed-off-by: lstocchi <lstocchi@redhat.com>

---------

Signed-off-by: lstocchi <lstocchi@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lstocchi lstocchi

Labels
area/dashboard 📊 Concern the dashboard from Container Desktop kind/bug 🐞 Something isn't working
Projects
Podman Desktop Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: replace backslash with slash so to support rendering on Windows (#3120) lstocchi/podman-desktop
3 participants
@benoitf @lstocchi @podman-desktop-bot