Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Tweak: Registries page #3233

Open
mairin opened this issue Jul 14, 2023 · 2 comments
Open

UI Tweak: Registries page #3233

mairin opened this issue Jul 14, 2023 · 2 comments
Assignees
Labels
area/ui kind/enhancement ✨ Issue for requesting an improvement

Comments

@mairin
Copy link
Member

mairin commented Jul 14, 2023

Is your enhancement related to a problem? Please describe

I think the visual styling on the Registries page is a little out of step with the rest of the app. It would be nice to update it for consistency / to better match styles established elsewhere in the app.

Here is a screenshot of how it looks in main today:

Screenshot from 2023-07-14 15-01-06

Two main issues stand out to me:

  • The table styling (both the header styling and the use of lines instead of space to delinate rows particularly)
  • The placement of the "Add Registry" action button, which on pretty much every other screen is placed in the upper right. I think it's easily missed on the bottom here.

Describe the solution you'd like

I would suggest something that looks like this:

Screenshot from 2023-07-14 15-01-06__@

This moves the action button to the upper left (vertically centered along the same line as the page headline "Registries") and it also changes the visual styling of the table to be more consistent with other tables (like the pods/containers/images tables.)

Describe alternatives you've considered

No response

Additional context

Note I changed the "Configure" button on suggested registries in the list to be the secondary "outline" form of the button, beacuse the "add registry" button should be the primary button on the page imo.

@mairin mairin added kind/enhancement ✨ Issue for requesting an improvement area/ui labels Jul 14, 2023
deboer-tim added a commit to deboer-tim/desktop that referenced this issue Jul 17, 2023
Fixes the initial/most basic part of issue containers#3233: adds support for adding actions
to the SettingsPage header and moves the Registries page Add registry button from
being bottom-right aligned into the header.

Signed-off-by: Tim deBoer <git@tdeboer.ca>
deboer-tim added a commit that referenced this issue Jul 18, 2023
Fixes the initial/most basic part of issue #3233: adds support for adding actions
to the SettingsPage header and moves the Registries page Add registry button from
being bottom-right aligned into the header.

Signed-off-by: Tim deBoer <git@tdeboer.ca>
Copy link
Contributor

This issue has been automatically marked as stale because it has not had activity in the last 6 months. It will be closed in 30 days if no further activity occurs. Please feel free to leave a comment if you believe the issue is still relevant. Thank you for your contributions!

@deboer-tim
Copy link
Collaborator

#3245 moved the New button to the header, and #5965 would clean up several alignment issues. Long term I think we need this issue still open to move this page to a Table, to solve these issues and for consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui kind/enhancement ✨ Issue for requesting an improvement
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants