fix: move new registry button to header #3245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the initial/most basic part of issue containers#3233: adds support for adding actions to the SettingsPage header and moves the Registries page Add registry button from being bottom-right aligned into the header. Signed-off-by: Tim deBoer <git@tdeboer.ca>
deboer-tim
requested review from
jeffmaury and
lstocchi
and removed request for
a team
benoitf
reviewed
Jul 17, 2023
| @@ -243,6 +243,19 @@ const processPasswordElement = (node: HTMLInputElement, registry: containerDeskt | |||
| </script> | |||
|
|
|||
| <SettingsPage title="Registries"> | |||
| <svelte:fragment slot="actions"> | |||
There was a problem hiding this comment.
do we need a svelte fragment to not break flow layout or just a div would be good ?
There was a problem hiding this comment.
A div would work fine, I was just running with the 'don't add an extra html component if it's not necessary'. You'd prefer I switch?
There was a problem hiding this comment.
I think a div would be simpler but I don't have a strong opinion.
There was a problem hiding this comment.
Switched, and turned on auto-merge.
benoitf
approved these changes
Jul 17, 2023
Switch to using a div. Signed-off-by: Tim deBoer <git@tdeboer.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the initial/most basic part of issue #3233: adds support for adding actions to the SettingsPage header and moves the Registries page Add registry button from being bottom-right aligned into the header.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
First part of issue #3233.
How to test this PR?
Open Settings > Registries page and confirm the button still works.