Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better handling for poor extension activation #3280

Closed
deboer-tim opened this issue Jul 19, 2023 · 0 comments · Fixed by #3446
Closed

Better handling for poor extension activation #3280

deboer-tim opened this issue Jul 19, 2023 · 0 comments · Fixed by #3446
Assignees
@benoitf
Labels
area/extensions 🧩 kind/bug 🐞 Something isn't working

Comments

@deboer-tim
Copy link
Collaborator

Bug description

See issue #3272 for some background, splitting this off for the general issue. I thought I had opened it before but can't find another atm.

If an extension hangs during activation or just takes a really long time, we should have a timeout or other strategies for marking the extension as failed/having issues and moving on. Currently one failing extension can cause a lot of problems since we have events waiting based on all extensions finishing loading.

Ditto for deactivation.

Operating system

macOS 13.4 M1

Installation Method

None

Version

next (development version)

Steps to reproduce

No response

Relevant log output

No response

Additional context

No response
@deboer-tim deboer-tim added the kind/bug 🐞 Something isn't working label Jul 19, 2023
@deboer-tim deboer-tim mentioned this issue Jul 19, 2023
Closed
@benoitf benoitf self-assigned this Jul 26, 2023
benoitf added a commit to benoitf/desktop that referenced this issue Aug 7, 2023
@benoitf
fix: add maximum activation time for extensions
6055760 
after reaching that time, loader continue without waiting for this extension
extension is flagged as a failed extension

fixes containers#3280
fixes containers#2993

Signed-off-by: Florent Benoit <fbenoit@redhat.com>
@benoitf benoitf mentioned this issue Aug 7, 2023
Merged
benoitf added a commit to benoitf/desktop that referenced this issue Aug 21, 2023
@benoitf
fix: add maximum activation time for extensions
e952bf6 
after reaching that time, loader continue without waiting for this extension
extension is flagged as a failed extension

fixes containers#3280
fixes containers#2993

Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf added a commit to benoitf/desktop that referenced this issue Aug 22, 2023
@benoitf
fix: add maximum activation time for extensions
6875616 
after reaching that time, loader continue without waiting for this extension
extension is flagged as a failed extension

fixes containers#3280
fixes containers#2993

Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf added a commit that referenced this issue Aug 22, 2023
@benoitf
fix: add maximum activation time for extensions (#3446)
5a1f5e1 
* fix: add maximum activation time for extensions

after reaching that time (default is 10s), loader continue without waiting for this extension
extension is flagged as a failed extension

fixes #3280
fixes #2993

Signed-off-by: Florent Benoit <fbenoit@redhat.com>
mairin pushed a commit to mairin/podman-desktop that referenced this issue Aug 29, 2023
@benoitf @mairin
fix: add maximum activation time for extensions (containers#3446)
b0c3590 
* fix: add maximum activation time for extensions

after reaching that time (default is 10s), loader continue without waiting for this extension
extension is flagged as a failed extension

fixes containers#3280
fixes containers#2993

Signed-off-by: Florent Benoit <fbenoit@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benoitf benoitf

Labels
area/extensions 🧩 kind/bug 🐞 Something isn't working
Projects
Podman Desktop Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add maximum activation time for extensions benoitf/desktop
3 participants
@benoitf @deboer-tim @podman-desktop-bot