fix: add maximum activation time for extensions #3446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitf
requested review from
jeffmaury and
cdrage
and removed request for
a team
jeffmaury
reviewed
Aug 8, 2023
|
I'll check Yes, it does not prevent the activation (but it's not waiting that activate method returns before proceeding) If OpenShift local extension is not being activated in 5s I guess there is a big issue in the extension |
cdrage
approved these changes
Aug 9, 2023
There was a problem hiding this comment.
Was able to test this with https://github.com/crc-org/crc-extension but didn't run into the timeout issue (maybe I had less stuff running).
Should we change it to 10 seconds instead?
You're right though, there is something wrong with the extension if it's taking that long (should load fast, and THEN do whatever call is making it time out).
cdrage
requested changes
Aug 21, 2023
after reaching that time, loader continue without waiting for this extension extension is flagged as a failed extension fixes containers#3280 fixes containers#2993 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
cdrage
approved these changes
Aug 22, 2023
mairin
pushed a commit
to mairin/podman-desktop
that referenced
this pull request
Aug 29, 2023
* fix: add maximum activation time for extensions after reaching that time (default is 10s), loader continue without waiting for this extension extension is flagged as a failed extension fixes containers#3280 fixes containers#2993 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after reaching that time, loader continue without waiting for this extension extension is flagged as a failed extension
fixes #3280 fixes #2993
What does this PR do?
add maximum activation time for extensions (configurable)
after reaching that time, loader continue without waiting for this extension
extension is flagged as a failed extension
Screenshot/screencast of this PR
What issues does this PR fix or reference?
fixes #3280
fixes #2993
How to test this PR?
Unit test is provided
but you can also add a
await new Promise(r => setTimeout(r, 10000));instruction in one activate method of an extension(extension should report as having failed)