Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabling Registry Extension does nothing #3909

Closed
odockal opened this issue Sep 14, 2023 · 0 comments · Fixed by #4183
Closed

Disabling Registry Extension does nothing #3909

odockal opened this issue Sep 14, 2023 · 0 comments · Fixed by #4183
Assignees
@deboer-tim
Labels
area/registries kind/bug 🐞 Something isn't working

Comments

@odockal
Copy link
Contributor

odockal commented Sep 14, 2023

Bug description

I am expecting that if I disable registry, I will loose access to all default registry available in podman desktop. Even though I disable registry in extensions, nothing really happens. I still can pull images from these repositories.

Operating system

Windows 10

Installation Method

Installer from website/GitHub releases

Version

1.4.0

Steps to reproduce

  1. have podman running
  2. Extensions -> Registries
  3. Disable
  4. Check Settings -> Registries -> should be empty
  5. try to pull image -> should not work

Relevant log output

No response

Additional context

No response
@odockal odockal added kind/bug 🐞 Something isn't working area/registries labels Sep 14, 2023
deboer-tim added a commit that referenced this issue Oct 2, 2023
@deboer-tim
fix: remove suggested registries on deactivation
84f3bb6 
The suggested registries extension adds registries but never adds the disposable
subscription, so registries stay around even if you disable the extension. This
just adds the subscription.

There's a good argument to be made that suggested registries should be registered
more like commands or menu contributions, and since they'd be handled once by the
extension loader this bug could never happen again. That would require a breaking
API change and a much bigger PR though, so not sure it's worth it; either way I
think it's best for this change to go ahead and fix the immediate bug.

Fixes #3909.

Signed-off-by: Tim deBoer <git@tdeboer.ca>
@deboer-tim deboer-tim mentioned this issue Oct 2, 2023
Merged
deboer-tim added a commit that referenced this issue Oct 3, 2023
@deboer-tim
fix: remove suggested registries on deactivation
bad2c5a 
The suggested registries extension adds registries but never adds the disposable
subscription, so registries stay around even if you disable the extension. This
just adds the subscription.

There's a good argument to be made that suggested registries should be registered
more like commands or menu contributions, and since they'd be handled once by the
extension loader this bug could never happen again. That would require a breaking
API change and a much bigger PR though, so not sure it's worth it; either way I
think it's best for this change to go ahead and fix the immediate bug.

Fixes #3909.

Signed-off-by: Tim deBoer <git@tdeboer.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deboer-tim deboer-tim

Labels
area/registries kind/bug 🐞 Something isn't working
Projects
Podman Desktop Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove suggested registries on deactivation containers/podman-desktop
2 participants
@odockal @deboer-tim