fix: remove suggested registries on deactivation #4183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The suggested registries extension adds registries but never adds the disposable subscription, so registries stay around even if you disable the extension. This just adds the subscription. There's a good argument to be made that suggested registries should be registered more like commands or menu contributions, and since they'd be handled once by the extension loader this bug could never happen again. That would require a breaking API change and a much bigger PR though, so not sure it's worth it; either way I think it's best for this change to go ahead and fix the immediate bug. Fixes #3909. Signed-off-by: Tim deBoer <git@tdeboer.ca>
deboer-tim
requested review from
dgolovin and
lstocchi
and removed request for
a team
benoitf
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The suggested registries extension adds registries but never adds the disposable subscription, so registries stay around even if you disable the extension. This just adds the subscription.
There's a good argument to be made that suggested registries should be registered more like commands or menu contributions, and since they'd be handled once by the extension loader this bug could never happen again. That would require a breaking API change and a much bigger PR though, so not sure it's worth it; either way I think it's best for this change to go ahead and fix the immediate bug.
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
Fixes #3909.
How to test this PR?
Check that there are suggested registries in Settings > Registries, then disable the Registries extension in Settings > Extensions > Registries and go back to confirm they're gone.