Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If creating new resource fails when form has vertical scrolling the error is not visible #4229

Open
dgolovin opened this issue Oct 6, 2023 · 3 comments
Labels
area/ui kind/bug 🐞 Something isn't working status/need-design Issues that involve UI that needs design input / mockup / etc

Comments

@dgolovin
Copy link
Contributor

dgolovin commented Oct 6, 2023

Bug description

The form below just failed to create podman VM and I am wondering what happened.

image

I have to scroll the form up to see the error.

image

The error message Error: [object Object] is reported here #4230.

Operating system

macOS Sonoma 14.0

Installation Method

Other

Version

next (development version)

Steps to reproduce

No response

Relevant log output

No response

Additional context

No response

@deboer-tim
Copy link
Collaborator

Progress is shown up there too, so for a second yesterday I thought it hadn't done anything when I clicked Create.

A simple solution would be to auto-scroll to the top when we click Create, but I don't love it when forms move themselves. Alternately we could move progress/error/logs to the bottom, have some kind of floating control, or clear the properties.

FYI to @mairin, I've added this to the next UX discussion.

@mairin mairin added the status/need-design Issues that involve UI that needs design input / mockup / etc label Oct 22, 2023
deboer-tim added a commit that referenced this issue Dec 13, 2023
I'm pretty sure this was an idea from Mo. Adds a linear progress bar at the
bottom of the FormPage header to indicate that something is 'in progress',
and uses this when building and pulling images, playing kube, deploying pods,
creating pods from containers, creating volumes, and creating resources
(container or Kubernetes).

This helps to indicate that there's 'something happening', especially in
cases like #4229 where you can't see another progress monitor in the view.

This 'duplicates' the progress monitor when creating a container/Kubernetes
instance, but I don't want to remove that as these pages are also used during
onboarding and the original/smaller one helps draw your eye to the Show Logs
expander. IMHO having two here is still an improvement.

Signed-off-by: Tim deBoer <git@tdeboer.ca>
benoitf pushed a commit that referenced this issue Dec 14, 2023
* feat: form progress

I'm pretty sure this was an idea from Mo. Adds a linear progress bar at the
bottom of the FormPage header to indicate that something is 'in progress',
and uses this when building and pulling images, playing kube, deploying pods,
creating pods from containers, creating volumes, and creating resources
(container or Kubernetes).

This helps to indicate that there's 'something happening', especially in
cases like #4229 where you can't see another progress monitor in the view.

This 'duplicates' the progress monitor when creating a container/Kubernetes
instance, but I don't want to remove that as these pages are also used during
onboarding and the original/smaller one helps draw your eye to the Show Logs
expander. IMHO having two here is still an improvement.

Signed-off-by: Tim deBoer <git@tdeboer.ca>

* chore: add tests

When you write a test, it helps if you include it in the commit. :)

Signed-off-by: Tim deBoer <git@tdeboer.ca>

---------

Signed-off-by: Tim deBoer <git@tdeboer.ca>
Copy link
Contributor

This issue has been automatically marked as stale because it has not had activity in the last 6 months. It will be closed in 30 days if no further activity occurs. Please feel free to leave a comment if you believe the issue is still relevant. Thank you for your contributions!

@deboer-tim
Copy link
Collaborator

Still a valid problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui kind/bug 🐞 Something isn't working status/need-design Issues that involve UI that needs design input / mockup / etc
Projects
Status: 📋 Backlog
Development

No branches or pull requests

5 participants