feat: form progress #5253
Merged
feat: form progress #5253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm pretty sure this was an idea from Mo. Adds a linear progress bar at the bottom of the FormPage header to indicate that something is 'in progress', and uses this when building and pulling images, playing kube, deploying pods, creating pods from containers, creating volumes, and creating resources (container or Kubernetes). This helps to indicate that there's 'something happening', especially in cases like #4229 where you can't see another progress monitor in the view. This 'duplicates' the progress monitor when creating a container/Kubernetes instance, but I don't want to remove that as these pages are also used during onboarding and the original/smaller one helps draw your eye to the Show Logs expander. IMHO having two here is still an improvement. Signed-off-by: Tim deBoer <git@tdeboer.ca>
deboer-tim
requested review from
dgolovin and
cdrage
and removed request for
a team
benoitf
reviewed
Dec 14, 2023
When you write a test, it helps if you include it in the commit. :) Signed-off-by: Tim deBoer <git@tdeboer.ca>
|
Lying in bed last night I was trying to remember if I actually included the test I wrote in the PR. 😂 There now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I'm pretty sure this was an idea from Mo. Adds a linear progress bar at the bottom of the FormPage header to indicate that something is 'in progress', and uses this when building and pulling images, playing kube, deploying pods, creating pods from containers, creating volumes, and creating resources (container or Kubernetes).
This helps to indicate that there's 'something happening', especially in cases like #4229 where you can't see another progress monitor in the view.
This 'duplicates' the progress monitor when creating a container/Kubernetes instance, but I don't want to remove that as these pages are also used during onboarding and the original/smaller one helps draw your eye to the Show Logs expander. IMHO having two here is still an improvement.
Screenshot / video of UI
Screen.Recording.2023-12-13.at.2.31.59.PM.mov
What issues does this PR fix or reference?
N/A
How to test this PR?
Perform any of these actions.