Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Docusaurus v3 #4581

Closed
deboer-tim opened this issue Nov 1, 2023 · 2 comments · Fixed by #4764
Closed

Upgrade to Docusaurus v3 #4581

deboer-tim opened this issue Nov 1, 2023 · 2 comments · Fixed by #4764
Assignees
@benoitf
Labels
area/documentation 📖 kind/enhancement ✨ Issue for requesting an improvement sprint/unplanned
Milestone
1.6.0

Comments

@deboer-tim
Copy link
Collaborator

Is your enhancement related to a problem? Please describe

Docusaurus v3 came out today with some enhancements. Opening an issue because there are a lot of underlying component upgrades so they say migration may be required (i.e. more than a dependabot), and they are already saying v2 will only get security fixes until end of January.

https://docusaurus.io/blog/preparing-your-site-for-docusaurus-v3
https://docusaurus.io/blog/releases/3.0

FYI @themr0c

Describe the solution you'd like

Upgrade to Docusaurus v3.

Describe alternatives you've considered

Docusaurus v2 forever!

Additional context

No response
@deboer-tim deboer-tim added the kind/enhancement ✨ Issue for requesting an improvement label Nov 1, 2023
@benoitf benoitf self-assigned this Nov 8, 2023
benoitf added a commit to benoitf/desktop that referenced this issue Nov 8, 2023
@benoitf
chore: prepare for docusaurus v3
e873028 
related to containers#4581
and https://docusaurus.io/docs/migration/v3#using-the-mdx-checker-cli
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
@benoitf benoitf mentioned this issue Nov 8, 2023
Merged
benoitf added a commit to benoitf/desktop that referenced this issue Nov 8, 2023
@benoitf
chore: prepare for docusaurus v3
ef40685 
related to containers#4581
and https://docusaurus.io/docs/migration/v3#using-the-mdx-checker-cli
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf added a commit to benoitf/desktop that referenced this issue Nov 8, 2023
@benoitf
chore: prepare for docusaurus v3
a53453a 
related to containers#4581
and https://docusaurus.io/docs/migration/v3#using-the-mdx-checker-cli
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf added a commit to benoitf/desktop that referenced this issue Nov 9, 2023
@benoitf
chore: prepare for docusaurus v3
1478ea6 
related to containers#4581
and https://docusaurus.io/docs/migration/v3#using-the-mdx-checker-cli
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
@nichjones1 nichjones1 added this to the 1.6.0 milestone Nov 9, 2023
benoitf added a commit to benoitf/desktop that referenced this issue Nov 9, 2023
@benoitf
chore: prepare for docusaurus v3
6cc60a6 
related to containers#4581
and https://docusaurus.io/docs/migration/v3#using-the-mdx-checker-cli
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf added a commit to benoitf/desktop that referenced this issue Nov 9, 2023
@benoitf
chore: prepare for docusaurus v3
090ffa2 
related to containers#4581
and https://docusaurus.io/docs/migration/v3#using-the-mdx-checker-cli
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf added a commit to benoitf/desktop that referenced this issue Nov 10, 2023
@benoitf
chore: prepare for docusaurus v3
45d79ba 
related to containers#4581
and https://docusaurus.io/docs/migration/v3#using-the-mdx-checker-cli
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf added a commit that referenced this issue Nov 10, 2023
@benoitf
chore: prepare for docusaurus v3
a2c9b97 
related to #4581
and https://docusaurus.io/docs/migration/v3#using-the-mdx-checker-cli
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf added a commit to benoitf/desktop that referenced this issue Nov 10, 2023
@benoitf
chore: update to docusaurus v3.0.0
fdba545 
fixes containers#4581
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
@benoitf benoitf mentioned this issue Nov 10, 2023
Merged
benoitf added a commit to benoitf/desktop that referenced this issue Nov 17, 2023
@benoitf
chore: update to docusaurus v3.0.0
759cdca 
fixes containers#4581
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf added a commit to benoitf/desktop that referenced this issue Nov 17, 2023
@benoitf
chore: update to docusaurus v3.0.0
6724ee5 
fixes containers#4581
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf added a commit to benoitf/desktop that referenced this issue Nov 17, 2023
@benoitf
chore: update to docusaurus v3.0.0
61ac531 
fixes containers#4581
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf added a commit to benoitf/desktop that referenced this issue Nov 17, 2023
@benoitf
chore: update to docusaurus v3.0.0
3d7c50f 
fixes containers#4581
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf added a commit to benoitf/desktop that referenced this issue Nov 17, 2023
@benoitf
chore: update to docusaurus v3.0.0
06d013a 
fixes containers#4581
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf added a commit to benoitf/desktop that referenced this issue Nov 19, 2023
@benoitf
chore: update to docusaurus v3.0.0
2d770a6 
fixes containers#4581
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf added a commit to benoitf/desktop that referenced this issue Nov 19, 2023
@benoitf
chore: update to docusaurus v3.0.0
d4c20a7 
fixes containers#4581
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
@themr0c
Copy link
Contributor

themr0c commented Nov 20, 2023

Nice to have: Use the .mdx extension to follow the recommendations in https://docusaurus.io/docs/migration/v3#using-the-mdx-extension

Using the .mdx extension
We recommend using the .mdx extension whenever you use JSX, import, or export (i.e. MDX features) inside a Markdown file. It is semantically more correct and improves compatibility with external tools (IDEs, formatters, linters, etc.).

@benoitf
Copy link
Collaborator

benoitf commented Nov 20, 2023

yes I saw that as well. It's recommended but for now it's still working.
I wanted to avoid to mix like the update to a newer version and the change of the extension files in one PR

benoitf added a commit to benoitf/desktop that referenced this issue Nov 21, 2023
@benoitf
chore: update to docusaurus v3.0.0
04456ee 
fixes containers#4581
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf added a commit to benoitf/desktop that referenced this issue Nov 21, 2023
@benoitf
chore: update to docusaurus v3.0.0
382538a 
fixes containers#4581
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf added a commit to benoitf/desktop that referenced this issue Nov 22, 2023
@benoitf
chore: update to docusaurus v3.0.0
cfeab46 
fixes containers#4581
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
cdrage pushed a commit that referenced this issue Nov 22, 2023
@benoitf
chore: update to docusaurus v3.0.0 (#4764)
194f1ed 
fixes #4581
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benoitf benoitf

Labels
area/documentation 📖 kind/enhancement ✨ Issue for requesting an improvement sprint/unplanned
Projects
Podman Desktop Planning
Archived in project
Milestone
1.6.0
Development

Successfully merging a pull request may close this issue.

chore: update to docusaurus v3.0.0 benoitf/desktop
6 participants
@themr0c @benoitf @jeffmaury @deboer-tim @podman-desktop-bot @nichjones1