Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to docusaurus v3.0.0 #4764

Merged
merged 1 commit into from Nov 22, 2023
Merged

Conversation

benoitf
Copy link
Collaborator

@benoitf benoitf commented Nov 10, 2023

Signed-off-by: Florent Benoit fbenoit@redhat.com

What does this PR do?

Update website to the new version of docusaurus v3.0.0

https://docusaurus.io/blog/releases/3.0

We should rename all .md files using imports to .mdx but it can be delayed

Screenshot/screencast of this PR

What issues does this PR fix or reference?

fixes #4581

How to test this PR?

@benoitf benoitf requested review from slemeur, themr0c and a team as code owners November 10, 2023 14:01
@benoitf benoitf requested review from dgolovin and feloy and removed request for a team November 10, 2023 14:01
@benoitf benoitf marked this pull request as draft November 10, 2023 14:17
@benoitf
Copy link
Collaborator Author

benoitf commented Nov 10, 2023

  • icons are broken

@benoitf
Copy link
Collaborator Author

benoitf commented Nov 17, 2023

icons have been fixed by renaming <icon to <Icon in #4856

@benoitf
Copy link
Collaborator Author

benoitf commented Nov 17, 2023

it looks we have block / syntax highlight issues (from screenshots)

@benoitf benoitf force-pushed the DESKTOP-4581c branch 6 times, most recently from 2d770a6 to d4c20a7 Compare November 19, 2023 16:54
@benoitf benoitf marked this pull request as ready for review November 19, 2023 16:54
@benoitf
Copy link
Collaborator Author

benoitf commented Nov 20, 2023

ok added the missing json and bash language for prism (language highlight as they're not enabled by default)

ready to be reviewed

@benoitf
Copy link
Collaborator Author

benoitf commented Nov 21, 2023

I've rebased this morning due to a conflicting yarn.lock

@jeffmaury
Copy link
Contributor

@benoitf can you rebase again

@benoitf
Copy link
Collaborator Author

benoitf commented Nov 21, 2023

@jeffmaury done

@benoitf
Copy link
Collaborator Author

benoitf commented Nov 21, 2023

@jeffmaury should be good now

Copy link
Collaborator

@deboer-tim deboer-tim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, compared against current website and could not find differences.

@benoitf
Copy link
Collaborator Author

benoitf commented Nov 22, 2023

need to rebase again 🤦

fixes containers#4581
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
Copy link
Contributor

@cdrage cdrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked netlify / tested this locally and LGTM!

Let's get this in before we have to rebase / merge a bunch again 👍

@cdrage cdrage enabled auto-merge (squash) November 22, 2023 14:59
@cdrage cdrage merged commit 194f1ed into containers:main Nov 22, 2023
14 checks passed
@podman-desktop-bot podman-desktop-bot added this to the 1.6.0 milestone Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Docusaurus v3
5 participants