Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show connection endpoint instead of provider information for containers #4727

Closed
afbjorklund opened this issue Nov 9, 2023 · 1 comment · Fixed by #5098
Closed

Show connection endpoint instead of provider information for containers #4727

afbjorklund opened this issue Nov 9, 2023 · 1 comment · Fixed by #5098
Labels
area/dashboard 📊 Concern the dashboard from Container Desktop area/ui kind/enhancement ✨ Issue for requesting an improvement

Comments

@afbjorklund
Copy link
Contributor

afbjorklund commented Nov 9, 2023

Is your enhancement related to a problem? Please describe

Currently the provider information is shown for containers, where the connection information is shown for Kubernetes.

This makes it somewhat confusing, when they are shown side by side or when connection name does not match provider.

Like here:

lima-provider-both

Describe the solution you'd like

It would be better if the resources showed the endpoints in a similar matter (with the URL), for both types of connections.

And the provider information should probably move to the "left hand side", and not be repeated for every connection ?

podman-desktop-provider-endpoint

Note: this is just showing the raw values (type and socketPath), and has some additional features like name and version

The provider type should be Capitalized, and one might consider truncating long URLs (or only show the path.basepath)

Describe alternatives you've considered

No response

Additional context

No response


PoC:

              <div class="mt-2">
                <div class="text-gray-700 text-xs">{container.type} endpoint</div>
                <div class="mt-1">
                  <span class="my-auto text-xs" class:text-gray-900="{container.status !== 'started'}"
                    >unix://{container.endpoint.socketPath}</span>
                </div>
              <div class="mt-2">
                <div class="text-gray-700 text-xs">Kubernetes endpoint</div>
                <div class="mt-1">
                  <span class="my-auto text-xs" class:text-gray-900="{kubeConnection.status !== 'started'}"
                    >{kubeConnection.endpoint.apiURL}</span>
                </div>
              </div>
@afbjorklund afbjorklund added the kind/enhancement ✨ Issue for requesting an improvement label Nov 9, 2023
@benoitf benoitf added area/dashboard 📊 Concern the dashboard from Container Desktop area/ui and removed status/need-triage labels Nov 10, 2023
@afbjorklund
Copy link
Contributor Author

afbjorklund commented Dec 11, 2023

The main downside with this change, is that the summary is now identical to the details.
So maybe the socketpath and url should be hidden from the summary, only show type ?

Docker
RUNNING
Docker endpoint
/var/run/docker.sock
Docker

Summary
Name: Docker
Type: Docker
Endpoint: /var/run/docker.sock

And perhaps move the version, either to the provider (left hand) - or even to the CLI...
Depending on if it should only show the client version (like today), or the server version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard 📊 Concern the dashboard from Container Desktop area/ui kind/enhancement ✨ Issue for requesting an improvement
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants