feat: show lima version #3748
Closed
feat: show lima version #3748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afbjorklund
requested review from
dgolovin and
cdrage
and removed request for
a team
benoitf
requested changes
Sep 4, 2023
| let provider; | ||
| if (fs.existsSync(socketPath) || fs.existsSync(configPath)) { | ||
| provider = extensionApi.provider.createProvider({ | ||
| name: 'Lima', | ||
| id: 'lima', | ||
| status: 'unknown', | ||
| version, |
There was a problem hiding this comment.
it might be better to update the version when you've the result and not hold the activate method
activate method should be a 'fast call', (as we wait the ending of the activate method on all extensions before showing the UI)
so probably, in activate you register the provider, then asynchronously you grab the version and call provider.updateVersion
There was a problem hiding this comment.
It's a local binary, but sure. (i.e. it takes 50 ms to run, unlike podman version which takes 5 seconds)
3 tasks
afbjorklund
force-pushed
the
lima-version
branch
from
af69b3b
to
88abcec
Compare
Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
afbjorklund
force-pushed
the
lima-version
branch
from
88abcec
to
b5fd055
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Finds the location of the
limactlbinary, and show the version of Lima.Screenshot/screencast of this PR
What issues does this PR fix or reference?
How to test this PR?
brew install limalimactl start template://podman