feat: show container connection type and endpoint #5098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afbjorklund
requested review from
dgolovin and
jeffmaury
and removed request for
a team
benoitf
reviewed
Dec 4, 2023
packages/renderer/src/lib/preferences/PreferencesResourcesRendering.svelte
Outdated
Show resolved
Hide resolved
Make the container and the kubernetes endpoint look more similar. Show the connection type, since it might not match the provider. Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
benoitf
approved these changes
Dec 5, 2023
Closed
|
Merging for being part of 1.6.0 release. |
rostalan
pushed a commit
to rostalan/podman-desktop
that referenced
this pull request
Dec 11, 2023
Make the container and the kubernetes endpoint look more similar. Show the connection type, since it might not match the provider. Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the container and the kubernetes endpoint look more similar.
Show the connection type, since it might not match the provider.
What does this PR do?
Screenshot/screencast of this PR
What issues does this PR fix or reference?
Fixes #4727
How to test this PR?