push image to cluster should not use kebab menu icon #4763
Labels
area/dashboard 📊
Concern the dashboard from Container Desktop
good first issue 🧁
Good for newcomers
kind/bug 🐞
Something isn't working
lifecycle/stale
Comments
benoitf
added
area/dashboard 📊
deboer-tim
added a commit
that referenced
this issue
Dec 12, 2023
We've had several people get confused with actions contributed by extensions that show up as an ellipsis icon in popup menus and Detail pages. The correct/full fix will require us to allow commands to provide their own icons, and to do this for all of the current extensions. This is not that fix. :) The other two things we should do is switch the default icon so that it doesn't use the same icon as our popup menus, and to pass the detailed property through the ContributionActions component so that these icons show up on buttons on the Details pages like the other actions. This is that part of the fix! I went through FA trying to find a more suitable icon and this is the best I could come up with. I preferred it to icons like the puzzle piece and I think it still gives some indication that the action comes from an extension. First step toward fixing #4763. Signed-off-by: Tim deBoer <git@tdeboer.ca>
deboer-tim
added a commit
that referenced
this issue
Dec 12, 2023
We've had several people get confused with actions contributed by extensions that show up as an ellipsis icon in popup menus and Detail pages. The correct/full fix will require us to allow commands to provide their own icons, and to do this for all of the current extensions. This is not that fix. :) The other two things we should do is switch the default icon so that it doesn't use the same icon as our popup menus, and to pass the detailed property through the ContributionActions component so that these icons show up on buttons on the Details pages like the other actions. This is that part of the fix! I went through FA trying to find a more suitable icon and this is the best I could come up with. I preferred it to icons like the puzzle piece and I think it still gives some indication that the action comes from an extension. First step toward fixing #4763. Signed-off-by: Tim deBoer <git@tdeboer.ca>
benoitf
pushed a commit
that referenced
this issue
Dec 12, 2023
We've had several people get confused with actions contributed by extensions that show up as an ellipsis icon in popup menus and Detail pages. The correct/full fix will require us to allow commands to provide their own icons, and to do this for all of the current extensions. This is not that fix. :) The other two things we should do is switch the default icon so that it doesn't use the same icon as our popup menus, and to pass the detailed property through the ContributionActions component so that these icons show up on buttons on the Details pages like the other actions. This is that part of the fix! I went through FA trying to find a more suitable icon and this is the best I could come up with. I preferred it to icons like the puzzle piece and I think it still gives some indication that the action comes from an extension. First step toward fixing #4763. Signed-off-by: Tim deBoer <git@tdeboer.ca>
benoitf
pushed a commit
that referenced
this issue
Dec 12, 2023
We've had several people get confused with actions contributed by extensions that show up as an ellipsis icon in popup menus and Detail pages. The correct/full fix will require us to allow commands to provide their own icons, and to do this for all of the current extensions. This is not that fix. :) The other two things we should do is switch the default icon so that it doesn't use the same icon as our popup menus, and to pass the detailed property through the ContributionActions component so that these icons show up on buttons on the Details pages like the other actions. This is that part of the fix! I went through FA trying to find a more suitable icon and this is the best I could come up with. I preferred it to icons like the puzzle piece and I think it still gives some indication that the action comes from an extension. First step toward fixing #4763. Signed-off-by: Tim deBoer <git@tdeboer.ca>
benoitf
pushed a commit
to benoitf/desktop
that referenced
this issue
Dec 12, 2023
We've had several people get confused with actions contributed by extensions that show up as an ellipsis icon in popup menus and Detail pages. The correct/full fix will require us to allow commands to provide their own icons, and to do this for all of the current extensions. This is not that fix. :) The other two things we should do is switch the default icon so that it doesn't use the same icon as our popup menus, and to pass the detailed property through the ContributionActions component so that these icons show up on buttons on the Details pages like the other actions. This is that part of the fix! I went through FA trying to find a more suitable icon and this is the best I could come up with. I preferred it to icons like the puzzle piece and I think it still gives some indication that the action comes from an extension. First step toward fixing containers#4763. Signed-off-by: Tim deBoer <git@tdeboer.ca>
benoitf
pushed a commit
that referenced
this issue
Dec 12, 2023
We've had several people get confused with actions contributed by extensions that show up as an ellipsis icon in popup menus and Detail pages. The correct/full fix will require us to allow commands to provide their own icons, and to do this for all of the current extensions. This is not that fix. :) The other two things we should do is switch the default icon so that it doesn't use the same icon as our popup menus, and to pass the detailed property through the ContributionActions component so that these icons show up on buttons on the Details pages like the other actions. This is that part of the fix! I went through FA trying to find a more suitable icon and this is the best I could come up with. I preferred it to icons like the puzzle piece and I think it still gives some indication that the action comes from an extension. First step toward fixing #4763. Signed-off-by: Tim deBoer <git@tdeboer.ca>
|
This issue has been automatically marked as stale because it has not had activity in the last 6 months. It will be closed in 30 days if no further activity occurs. Please feel free to leave a comment if you believe the issue is still relevant. Thank you for your contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug description
this icon is being used for pushing an image but it feels that I could get a drop down menu as it's the icon for a kebab menu so it is confusing
Screen.Recording.2023-11-10.at.13.59.02.mov
Operating system
macOS
Installation Method
Other
Version
next (development version)
Steps to reproduce
use kind and OpenShift local extension
Relevant log output
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: