fix: improve default contribution action icon #5236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deboer-tim
requested review from
jeffmaury and
lstocchi
and removed request for
a team
deboer-tim
force-pushed
the
contribution-action
branch
from
4aece69
to
b9bd050
Compare
|
rebasing to trigger again sonar check |
We've had several people get confused with actions contributed by extensions that show up as an ellipsis icon in popup menus and Detail pages. The correct/full fix will require us to allow commands to provide their own icons, and to do this for all of the current extensions. This is not that fix. :) The other two things we should do is switch the default icon so that it doesn't use the same icon as our popup menus, and to pass the detailed property through the ContributionActions component so that these icons show up on buttons on the Details pages like the other actions. This is that part of the fix! I went through FA trying to find a more suitable icon and this is the best I could come up with. I preferred it to icons like the puzzle piece and I think it still gives some indication that the action comes from an extension. First step toward fixing #4763. Signed-off-by: Tim deBoer <git@tdeboer.ca>
benoitf
force-pushed
the
contribution-action
branch
from
b9bd050
to
8e17bb5
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We've had several people get confused with actions contributed by extensions that show up as an ellipsis icon in popup menus and Detail pages. The correct/full fix will require us to allow commands to provide their own icons, and to do this for all of the current extensions. This is not that fix. :)
The other two things we should do are:
This is that part of the fix!
I went through FA trying to find a more suitable icon and this is the best I could come up with. I preferred it to icons like the puzzle piece and I think it still gives some indication that the action comes from an extension.
Screenshot / video of UI
Before:
After:
What issues does this PR fix or reference?
First step toward fixing #4763.
How to test this PR?
Go to contribution actions, e.g. Image Details page. Use PR #5222 as well to see the popup on Images list.