No feedback when deleting an image #5474
Assignees
Labels
area/dashboard 📊
Concern the dashboard from Container Desktop
kind/enhancement ✨
Issue for requesting an improvement
Comments
deboer-tim
added a commit
that referenced
this issue
Jan 10, 2024
Images had an inUse flag that we used to determine which status icon to show or whether the image is delete-able. If you delete the image and there is any delay, there is no feedback in the UI and you can delete it again (or accidentally click on the next image delete if the first one disappears at the wrong time). This changes images to have a status the same as most other types (e.g. pods, containers, deployments), so once the user clicks to delete it is marked for deletion (spinner in UI) and you can't delete again. Fixes #5474. Signed-off-by: Tim deBoer <git@tdeboer.ca>
deboer-tim
added a commit
that referenced
this issue
Jan 10, 2024
Images had an inUse flag that we used to determine which status icon to show or whether the image is delete-able. If you delete the image and there is any delay, there is no feedback in the UI and you can delete it again (or accidentally click on the next image delete if the first one disappears at the wrong time). This changes images to have a status the same as most other types (e.g. pods, containers, deployments), so once the user clicks to delete it is marked for deletion (spinner in UI) and you can't delete again. Fixes #5474. Signed-off-by: Tim deBoer <git@tdeboer.ca>
deboer-tim
added a commit
that referenced
this issue
Jan 10, 2024
Images had an inUse flag that we used to determine which status icon to show or whether the image is delete-able. If you delete the image and there is any delay, there is no feedback in the UI and you can delete it again (or accidentally click on the next image delete if the first one disappears at the wrong time). This changes images to have a status the same as most other types (e.g. pods, containers, deployments), so once the user clicks to delete it is marked for deletion (spinner in UI) and you can't delete again. Fixes #5474. Signed-off-by: Tim deBoer <git@tdeboer.ca>
deboer-tim
added a commit
that referenced
this issue
Jan 12, 2024
Images have an inUse flag that we use to determine which status icon to show or whether the image is delete-able. However, that means we cannot have other states like deleting or new. This changes images to have a status the same as most other types (e.g. pods, containers, deployments). This will allow future PRs to add additional states (e.g. deleting) and UI updates, e.g. so that you see a spinner if an image takes a second to delete. Step toward #5474. Signed-off-by: Tim deBoer <git@tdeboer.ca>
Merged
deboer-tim
added a commit
that referenced
this issue
Jan 15, 2024
Images have an inUse flag that we use to determine which status icon to show or whether the image is delete-able. However, that means we cannot have other states like deleting or new. This changes images to have a status the same as most other types (e.g. pods, containers, deployments). This will allow future PRs to add additional states (e.g. deleting) and UI updates, e.g. so that you see a spinner if an image takes a second to delete. Step toward #5474. Signed-off-by: Tim deBoer <git@tdeboer.ca>
benoitf
added
area/dashboard 📊
deboer-tim
added a commit
that referenced
this issue
Jan 24, 2024
Images have an inUse flag that we use to determine which status icon to show or whether the image is deletable. However, that means we cannot have other states like deleting or new. This changes images to have a status the same as most other types (e.g. pods, containers, deployments). This will allow future PRs to add additional states (e.g. deleting) and UI updates, e.g. so that you see a spinner if an image takes a second to delete. Step toward #5474. Signed-off-by: Tim deBoer <git@tdeboer.ca>
deboer-tim
added a commit
that referenced
this issue
Jan 24, 2024
Images have an inUse flag that we use to determine which status icon to show or whether the image is deletable. However, that means we cannot have other states like deleting or new. This changes images to have a status the same as most other types (e.g. pods, containers, deployments). This will allow future PRs to add additional states (e.g. deleting) and UI updates, e.g. so that you see a spinner if an image takes a second to delete. Step toward #5474. Signed-off-by: Tim deBoer <git@tdeboer.ca>
deboer-tim
added a commit
that referenced
this issue
Jan 25, 2024
Images have an inUse flag that we use to determine which status icon to show or whether the image is deletable. However, that means we cannot have other states like deleting or new. This changes images to have a status the same as most other types (e.g. pods, containers, deployments). This will allow future PRs to add additional states (e.g. deleting) and UI updates, e.g. so that you see a spinner if an image takes a second to delete. Step toward #5474. Signed-off-by: Tim deBoer <git@tdeboer.ca>
deboer-tim
added a commit
that referenced
this issue
Jan 26, 2024
Images have an inUse flag that we use to determine which status icon to show or whether the image is deletable. However, that means we cannot have other states like deleting or new. This changes images to have a status the same as most other types (e.g. pods, containers, deployments). This will allow future PRs to add additional states (e.g. deleting) and UI updates, e.g. so that you see a spinner if an image takes a second to delete. Step toward #5474. Signed-off-by: Tim deBoer <git@tdeboer.ca>
deboer-tim
added a commit
that referenced
this issue
Jan 26, 2024
Adds the 'DELETING' state to images so that a spinner appears while they are being deleted. Follows the identical pattern to pods, deployments, etc: - Add new status. - Set the status when deleting and fire an event. - Propagate event through ColumnActions. - List/Details trigger UI change. Fixes #5474. Signed-off-by: Tim deBoer <git@tdeboer.ca>
Merged
deboer-tim
added a commit
that referenced
this issue
Jan 26, 2024
Adds the 'DELETING' state to images so that a spinner appears while they are being deleted. Follows the identical pattern to pods, deployments, etc: - Add new status. - Set the status when deleting and fire an event. - Propagate event through ColumnActions. - List/Details trigger UI change. Fixes #5474. Signed-off-by: Tim deBoer <git@tdeboer.ca>
deboer-tim
added a commit
that referenced
this issue
Jan 26, 2024
Adds the 'DELETING' state to images so that a spinner appears while they are being deleted. Follows the identical pattern to pods, deployments, etc: - Add new status. - Set the status when deleting and fire an event. - Propagate event through ColumnActions. - List/Details trigger UI change. Fixes #5474. Signed-off-by: Tim deBoer <git@tdeboer.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your enhancement related to a problem? Please describe
When you delete an image, there's no feedback. Fine for small images which delete quickly, but when I delete a 1Gb image you can't tell if it's still trying to do it.
Describe the solution you'd like
Status icon should change to a spinner (deleting state) like on other pages. Should work in both the list and the details pages.
Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: