Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No feedback when deleting a volume #5614

Closed
deboer-tim opened this issue Jan 21, 2024 · 0 comments · Fixed by #5707
Closed

No feedback when deleting a volume #5614

deboer-tim opened this issue Jan 21, 2024 · 0 comments · Fixed by #5707
Assignees
Labels
area/dashboard 📊 Concern the dashboard from Container Desktop kind/enhancement ✨ Issue for requesting an improvement

Comments

@deboer-tim
Copy link
Collaborator

Is your enhancement related to a problem? Please describe

Same issue as #5474 for images - I was deleting a volume and it took a couple seconds with no feedback, so I about to click again (and would have deleted a second volume accidentally).

Describe the solution you'd like

Volumes should go into deleting status like other objects.

Describe alternatives you've considered

No response

Additional context

No response

@deboer-tim deboer-tim added the kind/enhancement ✨ Issue for requesting an improvement label Jan 21, 2024
@deboer-tim deboer-tim self-assigned this Jan 21, 2024
@benoitf benoitf added area/dashboard 📊 Concern the dashboard from Container Desktop and removed status/need-triage labels Jan 23, 2024
deboer-tim added a commit that referenced this issue Jan 24, 2024
Like #5528, volumes have an inUse flag that we use to determine which
status icon to show or whether the image is deletable. However, that
means we cannot have other states like deleting or new.

This changes images to have a status the same as most other types (e.g.
pods, containers, deployments). This will allow future PRs to add
additional states (e.g. deleting) and UI updates, e.g. so that you see
a spinner if an image takes a second to delete.

Step toward #5614.

Signed-off-by: Tim deBoer <git@tdeboer.ca>
benoitf pushed a commit that referenced this issue Jan 25, 2024
Like #5528, volumes have an inUse flag that we use to determine which
status icon to show or whether the image is deletable. However, that
means we cannot have other states like deleting or new.

This changes images to have a status the same as most other types (e.g.
pods, containers, deployments). This will allow future PRs to add
additional states (e.g. deleting) and UI updates, e.g. so that you see
a spinner if an image takes a second to delete.

Step toward #5614.

Signed-off-by: Tim deBoer <git@tdeboer.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard 📊 Concern the dashboard from Container Desktop kind/enhancement ✨ Issue for requesting an improvement
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants