Light mode for table columns #7348
Comments
deboer-tim
added a commit
to deboer-tim/desktop
that referenced
this issue
Jun 6, 2024
We have labels in several table columns: a rounded bg with a dot or icon + text. (re:naming - we already have 'badges', and these are like github labels) The existing labels have copied and inconsistent styling, so this creates a new Label component and reuses it for these cases. The name property provides the text and icon or dot goes in the slot, with optional tooltip. Image/pod had duplicate/unnecessary styling, removed rounded and text-sm. Removed styling checks from downstream tests. Part of containers#7348. Signed-off-by: Tim deBoer <git@tdeboer.ca>
deboer-tim
added a commit
to deboer-tim/desktop
that referenced
this issue
Jun 10, 2024
We have labels in several table columns: a rounded bg with a dot or icon + text. (re:naming - we already have 'badges', and these are like github labels) The existing labels have copied and inconsistent styling, so this creates a new Label component and reuses it for these cases. The name property provides the text and icon or dot goes in the slot, with optional tooltip. Image/pod had duplicate/unnecessary styling, removed rounded and text-sm. Removed styling checks from downstream tests. Part of containers#7348. Signed-off-by: Tim deBoer <git@tdeboer.ca>
deboer-tim
added a commit
that referenced
this issue
Jun 10, 2024
We have labels in several table columns: a rounded bg with a dot or icon + text. (re:naming - we already have 'badges', and these are like github labels) The existing labels have copied and inconsistent styling, so this creates a new Label component and reuses it for these cases. The name property provides the text and icon or dot goes in the slot, with optional tooltip. Image/pod had duplicate/unnecessary styling, removed rounded and text-sm. Removed styling checks from downstream tests. Part of #7348. Signed-off-by: Tim deBoer <git@tdeboer.ca>
|
@feloy did more of the work than I thought in #7151, then @cdrage did all the Kubernetes tables and pods via #7584. I fixed labels in #7502 and status colors in #7607, and containers is up for review in #7424. I'm going to take another pass through everything, but most of this work is complete through other issues. 👍🏼 |
deboer-tim
added a commit
to deboer-tim/desktop
that referenced
this issue
Jun 13, 2024
Reviewed all tables for light mode. Overall everything was great, just found a few minor things to fix: - Pod age & ingress/route backend - highlight is typically reserved for primary column, these should be normal text. - Ingress host path - clean up hard-coded color. Fixes containers#7348. Signed-off-by: Tim deBoer <git@tdeboer.ca>
cdrage
pushed a commit
to cdrage/podman-desktop
that referenced
this issue
Jun 19, 2024
We have labels in several table columns: a rounded bg with a dot or icon + text. (re:naming - we already have 'badges', and these are like github labels) The existing labels have copied and inconsistent styling, so this creates a new Label component and reuses it for these cases. The name property provides the text and icon or dot goes in the slot, with optional tooltip. Image/pod had duplicate/unnecessary styling, removed rounded and text-sm. Removed styling checks from downstream tests. Part of containers#7348. Signed-off-by: Tim deBoer <git@tdeboer.ca>
cdrage
pushed a commit
to cdrage/podman-desktop
that referenced
this issue
Jun 19, 2024
Reviewed all tables for light mode. Overall everything was great, just found a few minor things to fix: - Pod age & ingress/route backend - highlight is typically reserved for primary column, these should be normal text. - Ingress host path - clean up hard-coded color. Fixes containers#7348. Signed-off-by: Tim deBoer <git@tdeboer.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your enhancement related to a problem? Please describe
Tables have light mode support, but there are several columns in various tables that do not.
Describe the solution you'd like
Define any missing colors in the light mode palette (hopefully these are mostly done for other places) and get all the main tables working correctly in light mode.
Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: