Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add light mode to k8s tables #7584

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

cdrage
Copy link
Contributor

@cdrage cdrage commented Jun 11, 2024

chore: add light mode to k8s tables

What does this PR do?

Adds light mode for kubernetes tables / areas where the colour was
harcoded.

Screenshot / video of UI

Screen.Recording.2024-06-11.at.10.14.03.AM.mov

What issues does this PR fix or reference?

Closes #7574

How to test this PR?

  • Tests cover change

Test in light and dark mode.

Signed-off-by: Charlie Drage charlie@charliedrage.com

@cdrage cdrage requested review from benoitf and a team as code owners June 11, 2024 14:50
@cdrage cdrage requested review from dgolovin and lstocchi and removed request for a team June 11, 2024 14:50
### What does this PR do?

Adds light mode for kubernetes tables / areas where the colour was
harcoded.

### Screenshot / video of UI

<!-- If this PR is changing UI, please include
screenshots or screencasts showing the difference -->

### What issues does this PR fix or reference?

<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->

Closes containers#7574

### How to test this PR?

<!-- Please explain steps to verify the functionality,
do not forget to provide unit/component tests -->

- [X] Tests cover change

Test in light and dark mode.

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
@cdrage cdrage force-pushed the kubernetes-dashboard-light branch from a7dcdda to bedaa4b Compare June 11, 2024 14:50
Copy link
Contributor

@axel7083 axel7083 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great !

@cdrage cdrage merged commit 654ee75 into containers:main Jun 11, 2024
8 checks passed
@podman-desktop-bot podman-desktop-bot added this to the 1.11.0 milestone Jun 11, 2024
cdrage added a commit to cdrage/podman-desktop that referenced this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Light mode for Kubernetes dashboards / tables
4 participants