Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light mode for Kubernetes dashboards / tables #7574

Closed
Tracked by #4914
cdrage opened this issue Jun 11, 2024 · 0 comments · Fixed by #7584
Closed
Tracked by #4914

Light mode for Kubernetes dashboards / tables #7574

cdrage opened this issue Jun 11, 2024 · 0 comments · Fixed by #7584
Assignees
Labels

Comments

@cdrage
Copy link
Contributor

cdrage commented Jun 11, 2024

Is your enhancement related to a problem? Please describe

We have colours hardcoded for Kubernetes pages (especially the name in the table).

Screenshot 2024-06-11 at 8 11 01 AM

Describe the solution you'd like

Light mode

Describe alternatives you've considered

No response

Additional context

No response

@cdrage cdrage added the kind/enhancement ✨ Issue for requesting an improvement label Jun 11, 2024
@cdrage cdrage mentioned this issue Jun 11, 2024
45 tasks
@cdrage cdrage changed the title Light mode for Kubernetes pages Light mode for Kubernetes dashboards / tables Jun 11, 2024
@cdrage cdrage self-assigned this Jun 11, 2024
cdrage added a commit to cdrage/podman-desktop that referenced this issue Jun 11, 2024
### What does this PR do?

Adds light mode for kubernetes tables / areas where the colour was
harcoded.

### Screenshot / video of UI

<!-- If this PR is changing UI, please include
screenshots or screencasts showing the difference -->

### What issues does this PR fix or reference?

<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->

Closes containers#7574

### How to test this PR?

<!-- Please explain steps to verify the functionality,
do not forget to provide unit/component tests -->

N/A on tests as its a visual change.

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
cdrage added a commit to cdrage/podman-desktop that referenced this issue Jun 11, 2024
### What does this PR do?

Adds light mode for kubernetes tables / areas where the colour was
harcoded.

### Screenshot / video of UI

<!-- If this PR is changing UI, please include
screenshots or screencasts showing the difference -->

### What issues does this PR fix or reference?

<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->

Closes containers#7574

### How to test this PR?

<!-- Please explain steps to verify the functionality,
do not forget to provide unit/component tests -->

- [X] Tests cover change

Test in light and dark mode.

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
cdrage added a commit to cdrage/podman-desktop that referenced this issue Jun 11, 2024
### What does this PR do?

Adds light mode for kubernetes tables / areas where the colour was
harcoded.

### Screenshot / video of UI

<!-- If this PR is changing UI, please include
screenshots or screencasts showing the difference -->

### What issues does this PR fix or reference?

<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->

Closes containers#7574

### How to test this PR?

<!-- Please explain steps to verify the functionality,
do not forget to provide unit/component tests -->

- [X] Tests cover change

Test in light and dark mode.

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✔️ Done
Development

Successfully merging a pull request may close this issue.

2 participants